Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to change contract type #241

Closed
wants to merge 2 commits into from
Closed

Added ability to change contract type #241

wants to merge 2 commits into from

Conversation

qduk
Copy link
Contributor

@qduk qduk commented Oct 20, 2023

This is equivalent feature addition of #239 just for the LTM branch.

@progala
Copy link
Contributor

progala commented Oct 30, 2023

Thanks @qduk , it looks like the contract_types in this PR are different than the ones in #239 . I'm guessing the #239 are the ones we want here as well?

@bradh11 bradh11 changed the base branch from develop to ltm-1.6 October 31, 2023 14:16
@bradh11
Copy link
Contributor

bradh11 commented Oct 31, 2023

@qduk - This PR probably needs to be redone with the target branch as ltm1.6. There are too many items from 2.0 that are trying to merge in with ltm1.6 by way of me trying to retarget this PR manually.

@bradh11 bradh11 closed this Oct 31, 2023
@bradh11 bradh11 reopened this Oct 31, 2023
@bradh11 bradh11 changed the base branch from ltm-1.6 to develop October 31, 2023 14:19
@bradh11 bradh11 closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

@progala progala Awaiting requested review from progala progala is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qduk @progala @bradh11