Enable attachment of binary files as charm resources #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
dimaqq
reviewed
Oct 9, 2024
| @@ -2078,7 +2078,7 @@ def _upload(self, data, path, app_name, res_name, res_type, pending_id): | |||
|
|
|||
| headers['Content-Type'] = 'application/octet-stream' | |||
| headers['Content-Length'] = len(data) | |||
| headers['Content-Sha384'] = hashlib.sha384(bytes(data, 'utf-8')).hexdigest() | |||
| headers['Content-Sha384'] = hashlib.sha384(data).hexdigest() | |||
There was a problem hiding this comment.
This effectively changes the argument type from str to bytes.
There's one more call site at line 2141 that would have to be updated to match.
P.S. please add an explicit type hint on the argument.
|
@nrobinaubertin this PR needs some kind of test. ideally an integration test, or |
gfouillet
requested changes
Oct 10, 2024
6 tasks
|
Niels, I see that the PR where you needed this was closed. Do you have the bandwidth to update this PR? If not, I can maybe create an issue based on the PR and eventually someone else can pick this up. What you're fixing is basically a bug, as binary resources should be supported. |
|
This PR needs to be rebased since #1186 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables the attachment of binary files as charm resources.
Fixes: #1000