Add actions to control the new workload

[nrobinaubertin]

Overview

• Add actions to create/check/delete/list the ACLs
• Add a way to sideload a snap file for testing purposes. This does not work with the current libjuju without patching it, cf: Enable attachment of binary files as charm resources juju/python-libjuju#1147

Checklist

• The charm style guide was applied
• The contributing guide was applied
• The changes are compliant with ISD054 - Managing Charm Complexity
• The documentation is generated using src-docs
• The documentation for charmhub is updated
• The PR is tagged with appropriate label (urgent, trivial, complex)

[amandahla]

Nice PR!

Some points:

• I missed unit tests and failure tests
• For this one or a further PR: documentation on how to use charmed-bind-snap

[nrobinaubertin]

* I missed unit tests and failure tests

There's not a a lot of added logic in the charm for now, everything is mostly handled by the snap who has its own tests.
New tests will come when actually using these ACLs in the next PR

* For this one or a further PR: documentation on how to use charmed-bind-snap

This will be done in the next cycle for sure

[amandahla]

LGTM

[javierdelapuente]

A few comments

[javierdelapuente]

I am not sure about the use of multiple inheritance here using a mixin, as it is not going to be reused in other places.

As ActionsMixin only uses three variables (charm.on, charm.bind and charm.framework) I think an instance of tha class could be created with those variables explicitly passed, and so BindCharm and ActionsMixin are a bit less coupled.

[nrobinaubertin]

IMO, if we pass and instance of the class, they are tightly coupled. I'm doing the mixin dance to acknowledge it but still split the code in two.
This is in contrast to the bind service who can be tested outside of the charm instance.

[javierdelapuente]

Will this work without charmed-bind-snap?

[nrobinaubertin]

Yes, the CI is working without it. I'm just using it locally

[nrobinaubertin]

Okay, my bad. Doesn't work in the last CI anymore. Fixing...

[github-actions]

Test coverage for 75c5864

Name                               Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------------
lib/charms/bind/v0/dns_record.py     231     10     22      0    96%   324-329, 637-644
src/actions_mixin.py                  19     19      0      0     0%   9-92
src/bind.py                          140    140     32      0     0%   6-392
src/charm.py                         168    168     36      0     0%   7-337
src/constants.py                      14     14      0      0     0%   6-71
src/dns_data.py                       72     14     38      0    80%   38-51
src/events.py                          2      2      0      0     0%   7-10
src/exceptions.py                      3      3      0      0     0%   7-16
src/models.py                         33      5      4      0    81%   60-66, 111
------------------------------------------------------------------------------
TOTAL                                682    375    132      0    44%

Static code analysis report

Run started:2024-10-25 14:19:19.384032

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2722
  Total lines skipped (#nosec): 9
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

[nrobinaubertin]

Closing this as ACLs will be part of a DNS policy charm