Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jujubot auto-reply on external PRs needs love #1188

Open
james-garner-canonical opened this issue Nov 14, 2024 · 0 comments
Open

jujubot auto-reply on external PRs needs love #1188

james-garner-canonical opened this issue Nov 14, 2024 · 0 comments
Labels
area/nonpython Pull requests that updates non-Python code (bash, Makefile, etc.) kind/CI About CI infra or tests kind/doc indicates a documentation change priority/normal normal priority

Comments

@james-garner-canonical
Copy link
Contributor

Description

Current message:

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

Link 404s. The 'correct' link would be https://github.com/juju/juju/blob/main/doc/CONTRIBUTING.md, but even then there's a bunch of Juju specific information that doesn't apply here, such as "Bug reports should be filed on Launchpad, not GitHub".

We should link to python-libjuju CONTRIBUTING.md instead, but at the very least that should be updated to explain the juju conventional commits convention, e.g. linking here.

Also it seems to double post? (See here and here).

Also it should probably ping someone else, like @dimaqq and I.

Urgency

Casually reporting

Python-libjuju version

main

Juju version

n/a

Reproduce / Test

...
@james-garner-canonical james-garner-canonical added kind/bug indicates a bug in the project kind/CI About CI infra or tests kind/doc indicates a documentation change priority/normal normal priority area/nonpython Pull requests that updates non-Python code (bash, Makefile, etc.) and removed kind/bug indicates a bug in the project labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/nonpython Pull requests that updates non-Python code (bash, Makefile, etc.) kind/CI About CI infra or tests kind/doc indicates a documentation change priority/normal normal priority
Projects
None yet
Development

No branches or pull requests

1 participant