Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ClearFeature(ENDPOINT_HALT) #266

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Implement ClearFeature(ENDPOINT_HALT) #266

merged 1 commit into from
Jul 5, 2024

Conversation

miek
Copy link
Member

@miek miek commented Jun 19, 2024 •
edited
Loading

This is in draft until greatscottgadgets/python-usb-protocol#45 makes it into a release (and it probably needs a bit of cleanup), but it should work as-is for testing in the meantime.

This implements ClearFeature(ENDPOINT_HALT) as required by the USB 2.0 standard, I've also added an applet that can be used to test it out.

@antoinevg
Copy link
Member

greatscottgadgets/python-usb-protocol#45 is now available in: https://github.com/greatscottgadgets/python-usb-protocol/releases/tag/0.9.1

@martinling martinling linked an issue Jun 21, 2024 that may be closed by this pull request
Standard request handler should implement CLEAR_FEATURE request #166
Closed
@miek miek force-pushed the clear_endpoint_halt branch from eed631f to 26bd07f Compare June 21, 2024 09:40
@miek miek marked this pull request as ready for review June 21, 2024 09:43
@miek miek force-pushed the clear_endpoint_halt branch from 26bd07f to f787ef7 Compare June 21, 2024 10:23
@mndza mndza self-requested a review June 26, 2024 15:37
mndza
mndza requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@mndza mndza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've tested it and seems to work fine. I like the use of amaranth.lib.data. Just added a few minor comments about style.

@miek miek force-pushed the clear_endpoint_halt branch from f787ef7 to 4988b8d Compare July 5, 2024 08:16
@miek
Copy link
Member Author

miek commented Jul 5, 2024

Thanks! I've made those changes.

@miek miek requested a review from mndza July 5, 2024 08:19
@miek miek merged commit 13ad028 into greatscottgadgets:main Jul 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mndza mndza mndza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standard request handler should implement CLEAR_FEATURE request
3 participants
@miek @antoinevg @mndza