Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard request handler should implement CLEAR_FEATURE request #166

Closed
Tracked by #265
martinling opened this issue Apr 8, 2022 · 0 comments · Fixed by #266
Closed
Tracked by #265

Standard request handler should implement CLEAR_FEATURE request #166

martinling opened this issue Apr 8, 2022 · 0 comments · Fixed by #266
Labels
enhancement potential new feature

Comments

@martinling
Copy link
Member

There are a number of standard requests not currently implemented, but in particular, we should implement the CLEAR_FEATURE request with feature selector ENDPOINT_HALT.

This request should clear any halt condition on the target endpoint, and clear the data toggle bit. The host will usually only send this when recovering from a stall or error condition, but the request is allowed at any time.

Not handling this request led to bug greatscottgadgets/hackrf#1052, which was caused by the data toggle bits on host and device becoming out of sync.

On MacOS versions before 10.5, it was necessary to send this request after calling AbortPipe for an endpoint, because that function had the side effect of clearing the data toggle bit on the host.

At present, libusb on Darwin still sends this request as part of libusb_cancel_transfer, though that may be changed soon.

@straithe straithe added the enhancement potential new feature label Nov 9, 2022
@martinling martinling linked a pull request Jun 21, 2024 that will close this issue
@miek miek closed this as completed in #266 Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement potential new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants