-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(containers): update status #724
chore(containers): update status #724
Conversation
backend/lib/edgehog/triggers/handler/manual_actions/handle_trigger.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/triggers/handler/manual_actions/handle_trigger.ex
Outdated
Show resolved
Hide resolved
3c8d05c
to
9cf8e5b
Compare
backend/test/edgehog_web/controllers/astarte_trigger_controller_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog_web/controllers/astarte_trigger_controller_test.exs
Outdated
Show resolved
Hide resolved
0d5d37f
to
661b3f2
Compare
661b3f2
to
194c902
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
second round of review here we go
backend/lib/edgehog/containers/deployment/changes/check_containers.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/containers/deployment/changes/check_images.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/containers/deployment/changes/check_networks.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/triggers/handler/manual_actions/handle_trigger.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/containers/deployment/changes/check_containers.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/containers/deployment/changes/check_deployments.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/containers/deployment/changes/check_images.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/containers/deployment/changes/check_networks.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/containers/deployment/changes/check_networks.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/containers/manual_actions/filter_by_container.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/triggers/handler/manual_actions/handle_trigger.ex
Outdated
Show resolved
Hide resolved
bf2cb18
to
24f8f40
Compare
backend/lib/edgehog/containers/deployment/changes/check_containers.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/containers/deployment/changes/check_images.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/containers/deployment/changes/check_networks.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/triggers/handler/manual_actions/handle_trigger.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/triggers/handler/manual_actions/handle_trigger.ex
Outdated
Show resolved
Hide resolved
backend/test/edgehog_web/controllers/astarte_trigger_controller_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog_web/controllers/astarte_trigger_controller_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog_web/controllers/astarte_trigger_controller_test.exs
Outdated
Show resolved
Hide resolved
24f8f40
to
38b17a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're getting closer!
this round is mostly tests and a couple questions
backend/lib/edgehog/triggers/handler/manual_actions/handle_trigger.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/triggers/handler/manual_actions/handle_trigger.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/triggers/handler/manual_actions/handle_trigger.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/triggers/handler/manual_actions/handle_trigger.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/triggers/handler/manual_actions/handle_trigger.ex
Outdated
Show resolved
Hide resolved
backend/test/edgehog_web/controllers/astarte_trigger_controller_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog_web/controllers/astarte_trigger_controller_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog_web/controllers/astarte_trigger_controller_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog_web/controllers/astarte_trigger_controller_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog_web/controllers/astarte_trigger_controller_test.exs
Outdated
Show resolved
Hide resolved
ec2eb02
to
5c24440
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny leftovers
backend/lib/edgehog/containers/deployment/changes/check_images.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/triggers/handler/manual_actions/handle_trigger.ex
Outdated
Show resolved
Hide resolved
backend/test/edgehog_web/controllers/astarte_trigger_controller_test.exs
Outdated
Show resolved
Hide resolved
Deployment status update at each container interface trigger, status interface richer, expresses new deployment statuses: - `:created` when the backend has recived the deployment description - `:sent` when the deployment description has been sent to the device - `:pulled_images` when the device has pulled the necessary images - `:created_networks` when the device created the networks - `:created_containers` when the device created the necessary containers - `:created_deployment` when the device created the deployment - `:ready` when all resources have been created and the deployment is ready to be started Signed-off-by: Luca Zaninotto <[email protected]>
5c24440
to
0523f10
Compare
test happy path for triggers in `Available*` astarte interfaces Signed-off-by: Luca Zaninotto <[email protected]>
0523f10
to
c20be3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
59babfd
into
edgehog-device-manager:feature/application-management
Deployment status update at each container interface trigger, status interface richer, expresses new deployment statuses:
:created
when the backend has recived the deployment description:sent
when the deployment description has been sent to the device:puled_images
when the device has created all the image resources:created_networks
when the device has set up all the network resources:created_containers
when the device has created all the container resources:created_deployment
when the device has set up the deployment resource:ready
when all resources have been created and the deployment is ready to be started