Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(containers): update status #724

Conversation

lusergit
Copy link
Collaborator

@lusergit lusergit commented Nov 18, 2024

Deployment status update at each container interface trigger, status interface richer, expresses new deployment statuses:

  • :created when the backend has recived the deployment description
  • :sent when the deployment description has been sent to the device
  • :puled_images when the device has created all the image resources
  • :created_networks when the device has set up all the network resources
  • :created_containers when the device has created all the container resources
  • :created_deployment when the device has set up the deployment resource
  • :ready when all resources have been created and the deployment is ready to be started

@lusergit lusergit requested a review from noaccOS November 18, 2024 11:40
@lusergit lusergit force-pushed the chore/better-deployment-status branch 3 times, most recently from 3c8d05c to 9cf8e5b Compare November 19, 2024 17:52
@lusergit lusergit marked this pull request as ready for review November 19, 2024 17:52
@lusergit lusergit force-pushed the chore/better-deployment-status branch 2 times, most recently from 0d5d37f to 661b3f2 Compare November 20, 2024 09:53
@lusergit lusergit force-pushed the chore/better-deployment-status branch from 661b3f2 to 194c902 Compare November 20, 2024 11:38
@lusergit lusergit requested a review from noaccOS November 20, 2024 13:18
Copy link
Collaborator

@noaccOS noaccOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second round of review here we go

@lusergit lusergit force-pushed the chore/better-deployment-status branch from 24f8f40 to 38b17a0 Compare November 25, 2024 12:22
@lusergit lusergit requested a review from noaccOS November 25, 2024 13:47
Copy link
Collaborator

@noaccOS noaccOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're getting closer!
this round is mostly tests and a couple questions

@lusergit lusergit force-pushed the chore/better-deployment-status branch 3 times, most recently from ec2eb02 to 5c24440 Compare November 25, 2024 15:30
Copy link
Collaborator

@noaccOS noaccOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny leftovers

Deployment status update at each container interface trigger, status
interface richer, expresses new deployment statuses:
- `:created` when the backend has recived the deployment description
- `:sent` when the deployment description has been sent to the device
- `:pulled_images` when the device has pulled the necessary images
- `:created_networks` when the device created the networks
- `:created_containers` when the device created the necessary
  containers
- `:created_deployment` when the device created the deployment
- `:ready` when all resources have been created and the deployment is
  ready to be started

Signed-off-by: Luca Zaninotto <[email protected]>
@lusergit lusergit force-pushed the chore/better-deployment-status branch from 5c24440 to 0523f10 Compare November 25, 2024 15:48
test happy path for triggers in `Available*` astarte interfaces

Signed-off-by: Luca Zaninotto <[email protected]>
@lusergit lusergit force-pushed the chore/better-deployment-status branch from 0523f10 to c20be3d Compare November 25, 2024 15:51
Copy link
Collaborator

@noaccOS noaccOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@noaccOS noaccOS merged commit 59babfd into edgehog-device-manager:feature/application-management Nov 25, 2024
8 checks passed
@lusergit lusergit deleted the chore/better-deployment-status branch November 26, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants