feat(containers): deployment upgrade graphql api #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used to declare actions to run once the deployment hits `ready` state
mix ash.gen.resource Edgehog.Containers.DeploymentReadyAction.Upgrade \
--default-actions read,destroy \
--uuid-primary-key id \
--relationship belongs_to:upgrade_target:Edgehog.Containers.Deployment:required \
--domain Edgehog.Containers
mix ash.gen.resource Edgehog.Containers.DeploymentReadyAction \
--uuid-primary-key id \
--default-actions read,destroy \
--relationship belongs_to:deployment:Edgehog.Containers.Deployment:required \
--relationship belongs_to:upgrade_deployment:Edgehog.Containers.DeploymentReadyAction.Upgrade \
--attribute action_type:atom:required
Signed-off-by: Francesco Noacco <[email protected]>
Signed-off-by: Francesco Noacco <[email protected]>
noaccOS
force-pushed
the
feat/deployment_upgrade
branch
from
2494df5 to
9ccebf5
Compare
mix ash_postgres.generate_migrations add_deployment_ready_actions Signed-off-by: Francesco Noacco <[email protected]>
noaccOS
force-pushed
the
feat/deployment_upgrade
branch
2 times, most recently
from
013f651 to
5cc2a50
Compare
lusergit
requested changes
Nov 20, 2024
backend/lib/edgehog/containers/manual_actions/send_deployment_upgrade.ex
Outdated
Show resolved
Hide resolved
- change the device action to work with deployments instead of releases - move validations to the graphql api Co-authored-by: Luca Zaninotto <[email protected]> Signed-off-by: Francesco Noacco <[email protected]>
noaccOS
force-pushed
the
feat/deployment_upgrade
branch
from
5cc2a50 to
1ac2f59
Compare
lusergit
merged commit 10077d7
into
edgehog-device-manager:feature/application-management
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously #726
After irl discussion, will be changed to an update which will accept the existing deployment and the new release, and then both deploy and upgrade the release.Will need to figure out how to handle both deployments existing on the device, probably our best option would be to send a delete after the new version has been started.Implemented using a custom resource,
DeploymentReadyAction, which must be called when the deployment status is updated to ready.This must be done once #724 is merged