feat(containers): run ready actions when the deployment is ready #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noaccOS
force-pushed
the
feat/run-ready-action
branch
from
2795152 to
f81c876
Compare
noaccOS
force-pushed
the
feat/run-ready-action
branch
from
f81c876 to
bccdbc0
Compare
lusergit
reviewed
Nov 25, 2024
Comment on lines
35
to
40
| Enum.reduce_while(deployment.ready_actions, {:ok, deployment}, fn action, _acc -> | ||
| case Containers.run_ready_action(action) do | ||
| {:ok, _ready_action} -> {:cont, {:ok, deployment}} | ||
| {:error, reason} -> {:halt, {:error, reason}} | ||
| end | ||
| end) |
There was a problem hiding this comment.
Maybe here we don't actually want to halt if one ready action fails, I think it would be better to just run the ready action and let them crash if something happens
Suggested change
| Enum.reduce_while(deployment.ready_actions, {:ok, deployment}, fn action, _acc -> | |
| case Containers.run_ready_action(action) do | |
| {:ok, _ready_action} -> {:cont, {:ok, deployment}} | |
| {:error, reason} -> {:halt, {:error, reason}} | |
| end | |
| end) | |
| _ready_actions = Enum.map(deployment.ready_actions, &Containers.run_ready_action/1)) | |
| {:ok, deployment} |
There was a problem hiding this comment.
Hard to say now because we don't have any information on what we want to do with multiple ready actions for the same deployment.
It's a problem we will encounter once the situation arises
Signed-off-by: Francesco Noacco <[email protected]>
noaccOS
force-pushed
the
feat/run-ready-action
branch
from
bccdbc0 to
6c12827
Compare
lusergit
approved these changes
Nov 25, 2024
lusergit
merged commit 50c3ce5
into
edgehog-device-manager:feature/application-management
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drafted because it depends on #724 and 724 is not ready, but 2795152 is ready for review