simulated type fixes #4870
Merged
simulated type fixes #4870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
brian-mann
requested changes
Oct 23, 2019
packages/driver/test/cypress/integration/commands/actions/type_spec.js
Outdated
Show resolved
Hide resolved
packages/driver/test/cypress/integration/commands/actions/type_spec.js
Outdated
Show resolved
Hide resolved
packages/driver/test/cypress/integration/commands/actions/type_spec.js
Outdated
Show resolved
Hide resolved
| @@ -2822,6 +3018,10 @@ describe('src/cy/commands/actions/type', () => { | |||
| expect($input).to.have.value('FoO') | |||
| }) | |||
| }) | |||
|
|
|||
| it('{shift} does not capitalize characters', () => { | |||
| cy.get('input:first').type('{shift}foo').should('have.value', 'foo') | |||
There was a problem hiding this comment.
likely need a note here to describe our implementation logic of why we consider this to be correct
| cy | ||
| .get(':text:first').type(val) | ||
| .should('have.value', val) | ||
| describe('naughtly strings', () => { |
brian-mann
reviewed
Oct 23, 2019
| return chars | ||
| }) | ||
| } | ||
| throw Error(`Not a valid key: ${key}`) |
There was a problem hiding this comment.
i'm not sure this error can ever be hit
brian-mann
reviewed
Oct 23, 2019
packages/driver/test/cypress/integration/commands/actions/type_spec.js
Outdated
Show resolved
Hide resolved
… properties to regular exports - attach $Mouse + $Keyboard to Cypress
brian-mann
requested changes
Oct 23, 2019
This was referenced Oct 23, 2019
This was referenced Oct 23, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type validation during every character input, type following activeElement/focus
fix cy.type should follow activeElement #2240
fix not borrowing property getter for
maxLengthduring type validationfix Filling forms using Hyperform #4587
allow targeting any focusable element during
cy.typefix cy.get('button').type() only works if button has
tabindexspecified #2166fix Cannot type into a, link, or select element #3661
not updating value in
datetime-localinputfix Cannot type on datetime-local input #2613
allow typing minus(
-) sign into number field if entire field is selectedfix cannot
typenegative number into number input with text selection #4767fire input event when {enter} inserts newline
fix type('{enter}') doesn't fire input event #3405
don't input text when non-shift modifier is pressed
fix cy.type should not insert text when non-shift modifier key is pressed #5424
fire 'code' property on keyboard events
fix cy.type doesn't fill in KeyboardEvent.code #3722
use KeyboardEvent constructor instead of Event from app frameforcing certain property values on the event during and after construction is not stable (does not work in chrome 63)use host contenteditable as focusable element when targeting element inside contenteditable (should help with rich text editors)
remove need to intercept
selectcommand and keep cypress cursor state on form elementsTasks
cy.type, use definition ofisFocusableUX Changes:
error message on not typeable element
error message on not clearable element
type follows focus
Pre-merge Tasks