revert skipping text insert with modifier keys causing regression

[kuceb]

Breaking change introduced in 3.5.0 (#4870), where we would not insert text if non-shift modifier key was held down.

This broke quite a few people's tests because they wrote code unaware that the ctrl key is held down the entire rest of the sequence, e.g.:

cy.type('{ctrl}BHello')

people's app would capture the ctrl+B and bold the following text "hello"

the breaking change caused us to no longer insert the text "hello", thus the test was broken

• this PR reverts that behavior back to pre-3.5.0 and always inserts text regardless of modifiers

• Closes selectall / unselect regressions in 3.5.0, 3.6 #5622

User facing changelog

• fix regression introduced in 3.5.0 causing text after modifier keys not to be typed

Additional details

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• [NA] Has a PR for user-facing changes been opened in cypress-documentation?
• [NA] Have API changes been updated in the type definitions?
• [NA] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

3481 • 0 • 46 • 0

---

Run details

Project	cypress
Status	Passed
Commit	d3578fd
Started	Nov 7, 2019 8:50 PM
Ended	Nov 7, 2019 8:54 PM
Duration	03:51 💡
OS	Linux Debian - 9.8
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard