Update logic of actionability to check for "writability" only if the action is "typing"

[jennifer-shehane]

• close Cannot click on 'readonly' inputs / textarea #4874
• Write tests to ensure other actions happen appropriately on readonly elements

[cypress]

---

Test summary

3330 • 0 • 47 • 1

---

Run details

Project	cypress
Status	Passed
Commit	e29fda3
Started	Jul 30, 2019 10:58 AM
Ended	Jul 30, 2019 11:04 AM
Duration	05:49 💡
OS	Linux Debian - 8.10
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[kuceb]

I wouldn't pass actionType like that into actionability, I would let actionability take configuration on which ensures to verify not let it know about what command it is verifying for. This way it is a proper abstraction.

I've got that logic in a (wip) PR here #4870

Unless this needs to go out in a patch I suggest we close in favor of that PR

[brian-mann]

@bkucera can you help extract that logic and apply it to this PR?

[kuceb]

@brian-mann sure, so patch it is

Edit: here #4881

[jennifer-shehane]

@bkucera Yeah, I didn't like my own implementation haha. But wasn't sure how else to do it.

This PR will likely go out in 3.5.0, unless there are some other patch fixes in the meantime that necessitate 3.4.2. Not sure if your simulated type fixes will go in that fast. But - it's a regression that needs to be fixed asap.

[kuceb]

@jennifer-shehane well, thanks for the tests!

[kuceb]

closing in favor of #4881