Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuzzing] Updated the workflow and tried to simplify the OSS-fuzz and local fuzzing build. #168

Closed
wants to merge 1 commit into from

Conversation

pkillarjun
Copy link

  • Updated workflow to use all three sanitizers [address, undefined, memory];
  • Update the target under test to ini_parse_string from ini_parse for better coverage and ease of use and understanding.
  • Removed AFL fuzzer build and use only standard libFuzzer. Note, if you like to build with AFL++, you can use AFL++ official libAFLDriver.a library for libFuzzer targets.
  • After this PR merge, I will remove the build.sh from the official oss-fuzz repo and use oss-fuzz.sh for compilation in the oss-fuzz infrastructure.

Hey Benhoyt,
I will use this account to maintain all my OSS-Fuzz integrated projects.

…ied to simplify the OSS-fuzz and local fuzzing build.

Signed-off-by: Arjun <[email protected]>
@0x34d
Copy link
Contributor

0x34d commented Apr 24, 2024

Comment for Verification;

@pkillarjun
Copy link
Author

Everything is working as expected https://github.com/google/oss-fuzz/actions/runs/8821238582

@benhoyt
Copy link
Owner

benhoyt commented Apr 24, 2024

Hi @pkillarjun -- thanks for the contribution. I've thought about this further, and decided I don't have the time or knowledge to properly review OSS-Fuzz scripts and PRs. In addition, the 0x34d "Professional backdoor shipper" joke turned me off a bit. So I'm going to remove the OSS-Fuzz support from this repo. You're welcome to fork inih and add OSS-Fuzz support in your fork. I'm sorry about that!

@benhoyt benhoyt closed this Apr 24, 2024
@benhoyt benhoyt mentioned this pull request Apr 24, 2024
@pkillarjun
Copy link
Author

Well, I never dreamed of this response and #169.

@pkillarjun
Copy link
Author

pkillarjun commented Apr 25, 2024

You're welcome to fork inih and add OSS-Fuzz support in your fork. I'm sorry about that!

I hope you are okay with these changes?
google/oss-fuzz#11836
https://github.com/pkillarjun/oss-fuzz-src/commit/2f680c1722f8d0ce5731ee8defaa78e748c3049f https://github.com/pkillarjun/oss-fuzz-src/tree/main/inih

@benhoyt
Copy link
Owner

benhoyt commented Apr 25, 2024

I know it's not what you we're hoping for. But I appreciate you moving the oss-fuzz stuff to a fork. Those changes look reasonable to me!

@pkillarjun
Copy link
Author

I know it's not what you we're hoping for. But I appreciate you moving the oss-fuzz stuff to a fork. Those changes look reasonable to me!

I understand your thoughts on forks, but OSS-Fuzz does not accept forks of some random dude on the internet,
Don't worry, I will be managing this.

@DonggeLiu
Copy link

Hi @benhoyt, I am a maintainer of OSS-Fuzz.
May I double-check if you are still interested in using the OSS-Fuzz service (fuzzing inih, receiving reports, etc.)?
Thanks!

Just want to ensure that I understand the situation correctly : )

@benhoyt
Copy link
Owner

benhoyt commented May 1, 2024

@DonggeLiu I don't mind if someone else uses the OSS-Fuzz service to fuzz inih, and I'm happy to receive real bug reports, but I'd rather not maintain the fuzz code and scripts anymore in my inih repo.

@DonggeLiu
Copy link

Thanks for the confirmation, @benhoyt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants