Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inih] Fix Issue 68332 #11836

Merged
merged 1 commit into from
May 2, 2024
Merged

[inih] Fix Issue 68332 #11836

merged 1 commit into from
May 2, 2024

Conversation

pkillarjun
Copy link
Contributor

@pkillarjun pkillarjun commented Apr 24, 2024

Fix issue 68332 .

Copy link

pkillarjun is a new contributor to projects/inih. The PR must be approved by known contributors before it can be merged. The past contributors are: 0x34d

projects/inih/Dockerfile Outdated Show resolved Hide resolved
@pkillarjun pkillarjun changed the title [inih] Sifted build.sh into the main inih repo and updated my contact info. [inih] moved files and updated my contact info Apr 25, 2024
@pkillarjun pkillarjun changed the title [inih] moved files and updated my contact info [inih] Fix Issue 68332 and updated my contact info. Apr 28, 2024
@pkillarjun
Copy link
Contributor Author

summon @DonggeLiu

@DonggeLiu
Copy link
Contributor

Double-checking if I understand this correctly:
The inch maintainer is still interested in using OSS-Fuzz and receiving crash reports but does not want to maintain the fuzz target and build script in the inch repo.
You moved them to your own repo instead.

Also, could you please add a link to issue 68332 mentioned in the body of this PR?

@DonggeLiu
Copy link
Contributor

I see, thanks for confirming this.
Would you mind moving the files from your fork to this repo, e.g., like this?
https://github.com/google/oss-fuzz/tree/master/projects/abseil-cpp

Thanks!

@pkillarjun
Copy link
Contributor Author

pkillarjun commented Apr 30, 2024

Would you mind moving the files from your fork to this repo, e.g., like this?
https://github.com/google/oss-fuzz/tree/master/projects/abseil-cpp

I can, but I don't want to. This will make the oss-fuzz repo bloated.
Also, I will think about moving the build.sh back into the repo after proper confirmation from Ben Hoyt.

@pkillarjun pkillarjun changed the title [inih] Fix Issue 68332 and updated my contact info. [inih] Fix Issue 68332 and 0x34d is fine. Apr 30, 2024
@DonggeLiu
Copy link
Contributor

I can, but I don't want to. This will make the oss-fuzz repo bloated.

Yep, it will make OSS-Fuzz bloated. Hence, our first preference is to host those files in the project-under-test.
If that is not possible, hosting them in OSS-Fuzz (like many other projects) is our second preference for safety concerns.
We do appreciate your effort in helping integrate many projects.

Also, I will think about moving the build.sh back into the repo after proper confirmation from Ben Hoyt.

If possible, that would be our first preference. Meanwhile, we can always land the second preference now to unblock the project and improve later.

@pkillarjun pkillarjun changed the title [inih] Fix Issue 68332 and 0x34d is fine. [inih] Fix Issue 68332 May 1, 2024
@DonggeLiu DonggeLiu merged commit 28760cf into google:master May 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants