Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4132 - Update Form IO #4148

Merged
merged 5 commits into from
Dec 27, 2024
Merged

#4132 - Update Form IO #4148

merged 5 commits into from
Dec 27, 2024

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Dec 18, 2024

  • Updated form IO server version from 4.2.4 to 4.3.0
  • Upgraded "formiojs": "^4.21.4" to "@formio/js": "^5.0.0" for Web App
  • Fixed user interface issues due to the upgrade in Web App
    • Added CSS to remove extra text on file component that were hidden in previous versions.
    • Added CSS to show the "remove icon" and "calendar icon" which were hidden in the current version.
    • Changed HTML components to Text Field Components for displaying the awards on the Notice of Assessment page.
  • Changed fileMaxSize from "4 MB" to "15MB" for the file component pdDependentUpload for all program years.
  • Reverted clearOnHide for the file component dependantCustodyFileUpload for sfaa2025-2026.

Screenshot of the file component UI before and after the fix
image

Screenshot of the calendar icon before and after the fix
image

Screenshot of the NOA page due to Form.io upgrade without the fix
image

Screenshot of the NOA page using Text Field components to fix the rendering issues
image

@andrewsignori-aot andrewsignori-aot added the Form.io Form IO definitions changed. label Dec 18, 2024
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.22% ( 3783 / 17023 )
Methods: 10.18% ( 219 / 2151 )
Lines: 25.67% ( 3278 / 12772 )
Branches: 13.62% ( 286 / 2100 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 85.54% ( 1236 / 1445 )
Methods: 78.92% ( 131 / 166 )
Lines: 88.09% ( 1028 / 1167 )
Branches: 68.75% ( 77 / 112 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

@lewischen-aot lewischen-aot marked this pull request as ready for review December 26, 2024 21:30
Copy link
Collaborator Author

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes and thanks for the extra effort on the NOA issue. Looks good 👍

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the resource and for taking care of the update issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed. Web portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants