Skip to content

Commit

Permalink
#4132 - Update Form IO (#4148)
Browse files Browse the repository at this point in the history
- Updated form IO server version from 4.2.4 to 4.3.0 
- Upgraded `"formiojs": "^4.21.4"` to `"@formio/js": "^5.0.0"` for Web
App
- Fixed user interface issues due to the upgrade in Web App
- Added CSS to remove extra text on file component that were hidden in
previous versions.
- Added CSS to show the "remove icon" and "calendar icon" which were
hidden in the current version.
- Changed HTML components to **Text Field Components** for displaying
the awards on the Notice of Assessment page.
- Changed `fileMaxSize` from "4 MB" to "15MB" for the file component
`pdDependentUpload` for all program years.
- Reverted `clearOnHide` for the file component
`dependantCustodyFileUpload` for sfaa2025-2026.

Screenshot of the file component UI before and after the fix

![image](https://github.com/user-attachments/assets/ec03be17-f7fc-437c-ab82-7a92c5896e9a)

Screenshot of the calendar icon before and after the fix

![image](https://github.com/user-attachments/assets/bd1f78f8-8ed0-4500-bb0e-1ef278c8eed6)

Screenshot of the NOA page due to Form.io upgrade without the fix

![image](https://github.com/user-attachments/assets/7e81ab9d-939b-4063-b497-82ec21879acc)

Screenshot of the NOA page using Text Field components to fix the
rendering issues

![image](https://github.com/user-attachments/assets/8497734b-168d-4058-81c1-68d71aec98d0)

---------

Co-authored-by: Lewis Chen <[email protected]>
  • Loading branch information
andrewsignori-aot and lewischen-aot authored Dec 27, 2024
1 parent 454f69b commit cf57d13
Show file tree
Hide file tree
Showing 15 changed files with 5,011 additions and 8,491 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/env-setup-build-forms-server.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
description: "Formio tag, please refer https://github.com/formio/formio/tags to deploy the appropriate tag."
type: string
required: true
default: "v4.2.4"
default: "v4.3.0"

jobs:
build:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/env-setup-deploy-forms-server.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
description: "Formio tag, please refer https://github.com/formio/formio/tags to deploy the appropriate tag."
type: string
required: true
default: "v4.2.4"
default: "v4.3.0"

jobs:
deploy:
Expand Down
2 changes: 1 addition & 1 deletion devops/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export QUEUE_CONSUMERS_BUILD_REF := $(or ${QUEUE_CONSUMERS_BUILD_REF}, queue-con
export LOAD_TEST_GATEWAY_BUILD_REF := $(or ${LOAD_TEST_GATEWAY_BUILD_REF}, load-test-gateway-${APP_NAME})
export WEB_BUILD_REF := $(or ${WEB_BUILD_REF}, web-${APP_NAME})
export FORMS_BUILD_REF := $(or ${FORMS_BUILD_REF}, forms)
export FORMIO_SOURCE_REPO_TAG := $(or $(FORMIO_SOURCE_REPO_TAG), v4.2.4)
export FORMIO_SOURCE_REPO_TAG := $(or $(FORMIO_SOURCE_REPO_TAG), v4.3.0)
export FORMIO_ROOT_EMAIL := $(or ${FORMIO_ROOT_EMAIL}, [email protected])
export MONGODB_URI := $(or ${MONGODB_URI}, $$MONGODB_URI)
export QUEUE_PREFIX := $(or $(QUEUE_PREFIX), {sims-local})
Expand Down
2 changes: 1 addition & 1 deletion sources/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export SWAGGER_ENABLED := $(or ${SWAGGER_ENABLED}, true)
export APPLICATION_ARCHIVE_DAYS := $(or ${APPLICATION_ARCHIVE_DAYS}, 43)
#Formio forms integration
export FORMIO_SOURCE_REPO_URL := $(or ${FORMIO_SOURCE_REPO_URL}, https://github.com/formio/formio.git)
export FORMIO_SOURCE_REPO_TAG := $(or ${FORMIO_SOURCE_REPO_TAG}, v4.2.4)
export FORMIO_SOURCE_REPO_TAG := $(or ${FORMIO_SOURCE_REPO_TAG}, v4.3.0)
#ATBC Integration
export ATBC_USERNAME := $(or $(ATBC_USERNAME), )
export ATBC_PASSWORD := $(or $(ATBC_PASSWORD), )
Expand Down
11,849 changes: 4,587 additions & 7,262 deletions sources/packages/forms/src/form-definitions/noticeofassessment.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -13867,7 +13867,7 @@
}
],
"filePattern": ".pdf,.doc,.docx,.jpg,.png,.txt",
"fileMaxSize": "4 MB",
"fileMaxSize": "15MB",
"multiple": true,
"redrawOn": "dependants.declaredOnTaxes",
"validate": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13867,7 +13867,7 @@
}
],
"filePattern": ".pdf,.doc,.docx,.jpg,.png,.txt",
"fileMaxSize": "4 MB",
"fileMaxSize": "15MB",
"multiple": true,
"redrawOn": "dependants.declaredOnTaxes",
"validate": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13867,7 +13867,7 @@
}
],
"filePattern": ".pdf,.doc,.docx,.jpg,.png,.txt",
"fileMaxSize": "4 MB",
"fileMaxSize": "15MB",
"multiple": true,
"redrawOn": "dependants.declaredOnTaxes",
"validate": {
Expand Down
21 changes: 11 additions & 10 deletions sources/packages/forms/src/form-definitions/sfaa2025-26.json
Original file line number Diff line number Diff line change
Expand Up @@ -13429,8 +13429,7 @@
"inputType": "radio",
"fieldSet": false,
"id": "ea0vyrg",
"tags": [],
"isNew": false
"tags": []
},
{
"title": "Upload panel",
Expand Down Expand Up @@ -13521,7 +13520,8 @@
"addons": [],
"inputType": "hidden",
"id": "e52khib",
"tags": []
"tags": [],
"isNew": false
},
{
"label": "HTML",
Expand Down Expand Up @@ -13864,7 +13864,7 @@
}
],
"filePattern": ".pdf,.doc,.docx,.jpg,.png,.txt",
"fileMaxSize": "4 MB",
"fileMaxSize": "15MB",
"multiple": true,
"redrawOn": "dependants.declaredOnTaxes",
"validate": {
Expand All @@ -13888,7 +13888,7 @@
"unique": false,
"persistent": true,
"hidden": false,
"clearOnHide": false,
"clearOnHide": true,
"refreshOn": "",
"modalEdit": false,
"dataGridLabel": false,
Expand Down Expand Up @@ -14218,7 +14218,8 @@
"theme": "default",
"breadcrumb": "default",
"id": "ec900o",
"tags": []
"tags": [],
"isNew": false
},
{
"label": "Is the dependant listed above supported by you financially but not under your sole custody?",
Expand Down Expand Up @@ -14393,7 +14394,8 @@
"addons": [],
"inputType": "hidden",
"id": "ejf7zcr",
"tags": []
"tags": [],
"isNew": false
},
{
"label": "HTML",
Expand Down Expand Up @@ -14753,7 +14755,7 @@
"dbIndex": false,
"encrypted": false,
"redrawOn": "",
"clearOnHide": false,
"clearOnHide": true,
"customDefaultValue": "",
"calculateValue": "",
"calculateServer": false,
Expand Down Expand Up @@ -15095,8 +15097,7 @@
"breadcrumb": "default",
"id": "e88jxwl",
"hideLabel": true,
"tags": [],
"isNew": false
"tags": []
}
],
"id": "eja9nnp000000000000000000",
Expand Down
Loading

0 comments on commit cf57d13

Please sign in to comment.