PR review comments

bcgov · Dec 18, 2024 · 77ba677 · 77ba677
1 parent e5bb792
commit 77ba677
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/...c-integration/disbursement-receipt-integration/disbursement-receipt.processing.service.ts b/...c-integration/disbursement-receipt-integration/disbursement-receipt.processing.service.ts
@@ -81,7 +81,6 @@ export class DisbursementReceiptProcessingService {
     processSummary: ProcessSummary,
   ): Promise<void> {
     processSummary.info(`Processing file ${remoteFilePath}.`);
-    this.logger.log(`Starting download of file ${remoteFilePath}.`);
     let responseData: DisbursementReceiptDownloadResponse;
     try {
       responseData = await this.integrationService.downloadResponseFile(
@@ -107,7 +106,7 @@ export class DisbursementReceiptProcessingService {
           disbursementSchedule.id),
     );
 
-    this.logger.log(
+    processSummary.info(
       "Processing all the records in file with valid data and document number that belongs to SIMS.",
     );
 
@@ -147,7 +146,6 @@ export class DisbursementReceiptProcessingService {
         const logMessage = `Unexpected error while processing disbursement receipt record at line ${response.lineNumber}`;
         this.logger.error(logMessage, error);
         processSummary.error(logMessage, error);
-        return;
       }
     }
     processSummary.info(`Processing file ${remoteFilePath} completed.`);
@@ -222,9 +220,6 @@ export class DisbursementReceiptProcessingService {
       processSummary.info(
         "Provincial daily disbursement CSV report generated.",
       );
-      this.logger.log(
-        "Completed provincial daily disbursement report generation.",
-      );
     } catch (error: unknown) {
       const errorMessage =
         "Error while generating provincial daily disbursement CSV report file.";

diff --git a/...ns/src/esdc-integration/fed-restriction-integration/fed-restriction.processing.service.ts b/...ns/src/esdc-integration/fed-restriction-integration/fed-restriction.processing.service.ts
@@ -132,7 +132,7 @@ export class FedRestrictionProcessingService {
         const invalidDataMessage = restriction.getInvalidDataMessage();
         if (invalidDataMessage) {
           const errorMessage = `Found record with invalid data at line number ${restriction.lineNumber}: ${invalidDataMessage}`;
-          processSummary.error(errorMessage);
+          processSummary.warn(errorMessage);
           this.logger.error(errorMessage);
         } else {
           sanitizedRestrictions.push(restriction);