Pre-review

bcgov · Dec 18, 2024 · e5bb792 · e5bb792
1 parent 33bfe16
commit e5bb792
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 3 deletions.
diff --git a/...edulers/esdc-integration/ecert-integration/disbursement-receipts-integration.scheduler.ts b/...edulers/esdc-integration/ecert-integration/disbursement-receipts-integration.scheduler.ts
@@ -36,7 +36,6 @@ export class DisbursementReceiptsFileIntegrationScheduler extends BaseScheduler<
   }
 
   /**
-   * Logger for SFAS integration scheduler.
    * Setting the logger here allows the correct context to be set
    * during the property injection.
    * Even if the logger is not used, it is required to be set, to

diff --git a/...ntegration/federal-restrictions-integration/federal-restrictions-integration.scheduler.ts b/...ntegration/federal-restrictions-integration/federal-restrictions-integration.scheduler.ts
@@ -36,7 +36,6 @@ export class FederalRestrictionsIntegrationScheduler extends BaseScheduler<void>
   }
 
   /**
-   * Logger for SFAS integration scheduler.
    * Setting the logger here allows the correct context to be set
    * during the property injection.
    * Even if the logger is not used, it is required to be set, to

diff --git a/...onsumers/src/processors/schedulers/sfas-integration/sims-to-sfas-integration.scheduler.ts b/...onsumers/src/processors/schedulers/sfas-integration/sims-to-sfas-integration.scheduler.ts
@@ -68,7 +68,6 @@ export class SIMSToSFASIntegrationScheduler extends BaseScheduler<void> {
   }
 
   /**
-   * Logger for SFAS integration scheduler.
    * Setting the logger here allows the correct context to be set
    * during the property injection.
    * Even if the logger is not used, it is required to be set, to

diff --git a/...ns/src/esdc-integration/fed-restriction-integration/fed-restriction.processing.service.ts b/...ns/src/esdc-integration/fed-restriction-integration/fed-restriction.processing.service.ts
@@ -111,6 +111,7 @@ export class FedRestrictionProcessingService {
       const errorMessage = `Error downloading file ${remoteFilePath}.`;
       processSummary.error(errorMessage, error);
       this.logger.error(errorMessage, error);
+      return;
     }
 
     let insertedRestrictionsIDs: number[];