Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2059] Fix the debug-level log of wild card quota exceeded is always false #683

Closed
wants to merge 1 commit into from

Conversation

brandboat
Copy link
Member

What is this PR for?

Fix wildCardQuotaExceeded should be updated before logging it.

What type of PR is it?

  • - Bug Fix

Todos

N/A

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2059

How should this be tested?

N/A

Screenshots (if appropriate)

N/A

Questions:

N/A

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #683 (eb7b688) into master (efc21e0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #683   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files          79       79           
  Lines       13095    13095           
=======================================
  Hits        10175    10175           
  Misses       2595     2595           
  Partials      325      325           
Files Coverage Δ
pkg/scheduler/ugm/queue_tracker.go 91.59% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pbacsko pbacsko requested a review from manirajv06 October 26, 2023 11:31
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pbacsko pbacsko closed this in 358e3b4 Oct 26, 2023
@brandboat brandboat deleted the YUNIKORN-2059 branch October 26, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants