Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2059] Fix the debug-level log of wild card quota exceeded is always false #683

Closed
wants to merge 1 commit into from
Closed

[YUNIKORN-2059] Fix the debug-level log of wild card quota exceeded is always false #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/scheduler/ugm/queue_tracker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,15 +126,15 @@ func (qt *QueueTracker) increaseTrackedResource(hierarchy []string, applicationI
config = m.getGroupWildCardLimitsConfig(qt.queuePath)
}
if config != nil {
wildCardQuotaExceeded = (config.maxApplications != 0 && !existingApp && len(qt.runningApplications)+1 > int(config.maxApplications)) ||
(!resources.Equals(resources.NewResource(), config.maxResources) && resources.StrictlyGreaterThan(finalResourceUsage, config.maxResources))
log.Log(log.SchedUGM).Debug("applying enforcement checks using limit settings of wild card user/group",
zap.Int("tracking type", int(trackType)),
zap.String("queue path", qt.queuePath),
zap.Bool("existing app", existingApp),
zap.Uint64("wild card max running apps", config.maxApplications),
zap.Stringer("wild card max resources", config.maxResources),
zap.Bool("wild card quota exceeded", wildCardQuotaExceeded))
wildCardQuotaExceeded = (config.maxApplications != 0 && !existingApp && len(qt.runningApplications)+1 > int(config.maxApplications)) ||
(!resources.Equals(resources.NewResource(), config.maxResources) && resources.StrictlyGreaterThan(finalResourceUsage, config.maxResources))
if wildCardQuotaExceeded {
log.Log(log.SchedUGM).Warn("Unable to increase resource usage as allowing new application to run would exceed either configured max applications or max resources limit of wild card user/group",
zap.Int("tracking type", int(trackType)),
Expand Down