[YUNIKORN-2059] Fix the debug-level log of wild card quota exceeded i…

…s always false (#683) Closes: #683 Signed-off-by: Peter Bacsko <[email protected]>
apache · Oct 26, 2023 · 358e3b4 · 358e3b4
1 parent bc7c001
commit 358e3b4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/scheduler/ugm/queue_tracker.go b/pkg/scheduler/ugm/queue_tracker.go
@@ -126,15 +126,15 @@ func (qt *QueueTracker) increaseTrackedResource(hierarchy []string, applicationI
 			config = m.getGroupWildCardLimitsConfig(qt.queuePath)
 		}
 		if config != nil {
+			wildCardQuotaExceeded = (config.maxApplications != 0 && !existingApp && len(qt.runningApplications)+1 > int(config.maxApplications)) ||
+				(!resources.Equals(resources.NewResource(), config.maxResources) && resources.StrictlyGreaterThan(finalResourceUsage, config.maxResources))
 			log.Log(log.SchedUGM).Debug("applying enforcement checks using limit settings of wild card user/group",
 				zap.Int("tracking type", int(trackType)),
 				zap.String("queue path", qt.queuePath),
 				zap.Bool("existing app", existingApp),
 				zap.Uint64("wild card max running apps", config.maxApplications),
 				zap.Stringer("wild card max resources", config.maxResources),
 				zap.Bool("wild card quota exceeded", wildCardQuotaExceeded))
-			wildCardQuotaExceeded = (config.maxApplications != 0 && !existingApp && len(qt.runningApplications)+1 > int(config.maxApplications)) ||
-				(!resources.Equals(resources.NewResource(), config.maxResources) && resources.StrictlyGreaterThan(finalResourceUsage, config.maxResources))
 			if wildCardQuotaExceeded {
 				log.Log(log.SchedUGM).Warn("Unable to increase resource usage as allowing new application to run would exceed either configured max applications or max resources limit of wild card user/group",
 					zap.Int("tracking type", int(trackType)),