Do not make files lengths.npz and contignames #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files are redundant w.r.t. composition.npz. Although it takes more memory to load the latter, it's unlikely that storing the composition briefly is going to be a problem, since if it was, Vamb would cause OOM elsewhere anyway.
jakobnissen
added
the
Needs workflow run
|
I'm going to merge this, and we need to figure out some tests for these workflows before we release 5.0 anyway, so if this causes any bugs, we'll catch it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files are redundant w.r.t. composition.npz. Although it takes more memory to load the latter, it's unlikely that storing the composition briefly is going to be a problem, since if it was, Vamb would cause OOM elsewhere anyway.
Closes #302