Cache sampling of medoid #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobnissen
force-pushed
the
sample_cache
branch
from
61a56d5 to
01df4f4
Compare
This commit adds a cache to the sampling of the medoid in clustering. This allows the clusterer to fetch the results from a dict, if it's been previously computed. This will get merged only if benchmarks have verified that clustering actually runs faster - it's probable that so few medoids are sampled multiple times that the cache wastes more time in overhead than it saves in computation.
jakobnissen
force-pushed
the
sample_cache
branch
from
01df4f4 to
ebacfec
Compare
|
Wow, this is much faster, and consumes little extra memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a cache to the sampling of the medoid in clustering. This allows the clusterer to fetch the results from a dict, if it's been previously computed. This will get merged only if benchmarks have verified that clustering actually runs faster - it's probable that so few medoids are sampled multiple times that the cache wastes more time in overhead than it saves in computation.