Skip to content

Commit

Permalink
Do not ingore errors caught by Loguru
Browse files Browse the repository at this point in the history
In 62baa35, I added `@logger.catch` to `run` in order for Loguru to catch and
log any errors emitted by Vamb.
However, I did not notice that this will cause any caught errors to exit Vamb
with a return code of zero.
This broke CI and undoubtedly will break snakemake pipelines relying on Vamb.
  • Loading branch information
jakobnissen committed Jul 18, 2024
1 parent 7bdc15c commit 8401be0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion vamb/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1383,7 +1383,7 @@ def __init__(self, args):
def run_inner(self):
raise NotImplementedError

@logger.catch()
@logger.catch(reraise=True)
def run(self):
torch.set_num_threads(self.vamb_options.n_threads)
try_make_dir(self.vamb_options.out_dir)
Expand Down

0 comments on commit 8401be0

Please sign in to comment.