Skip to content

Commit

Permalink
Use the correct binsplitter in TaxVamb (#377)
Browse files Browse the repository at this point in the history
Previously, TaxVamb incorrectly used the inert splitter instead of the one
specified on command-line, when loading its composition.
Since the binsplitter is properly initialized in `calc_tnf`, such that it will
not attempt to binsplit on 'C' if this separator is not present, the use of an
inert splitter skipped this initialization.
This caused a bug where the lack of a separator was not detected until the data
was clustered, far too late.
  • Loading branch information
jakobnissen authored Dec 10, 2024
1 parent 95f1155 commit 77e1cba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion vamb/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1509,7 +1509,7 @@ def run_vaevae(opt: BinTaxVambOptions):
vamb_options=opt.common.general,
comp_options=opt.common.comp,
abundance_options=opt.common.abundance,
binsplitter=vamb.vambtools.BinSplitter.inert_splitter(),
binsplitter=opt.common.output.binsplitter,
)
abundance, tnfs, lengths, contignames = (
abundance.matrix,
Expand Down

0 comments on commit 77e1cba

Please sign in to comment.