fix(HMS-2785): pass otel spans properly #711
Conversation
pkg/worker/job.go
Outdated
| accountId := job.AccountID | ||
| id := job.Identity | ||
| logger := zerolog.Ctx(ctx).With(). | ||
| Str("trace_id", span.SpanContext().TraceID().String()). | ||
| Str("job_id", job.ID.String()). | ||
| Int64("account_id", accountId). | ||
| Str("account_number", id.Identity.AccountNumber). |
There was a problem hiding this comment.
Yeah this makes a lot of sense. In my patch, I put trace_id at reservation level but I think this is much better place. I will move it here but I will not add any otel related stuff and leave this to you so you can further develop this.
Great idea, in the end, we will have one trace (aka transaction in GlitchTip) and spans for api pod then one big span for the worker pod and additional spans for individual functions.
ezr-ondrej
force-pushed
the
root_spans
branch
from
fb2173d to
d48b974
Compare
ezr-ondrej
changed the title
ezr-ondrej
force-pushed
the
root_spans
branch
from
d48b974 to
d963b9b
Compare
Otel needs a root spans, if that is not passed from external service, we should start one ourselves, instead of starting span once we decide there is one needed internally. Also jobs and kafka shall retrieve these spans and continue, not start new spans.
ezr-ondrej
force-pushed
the
root_spans
branch
from
d963b9b to
30ebff0
Compare
|
/retest |
|
/retest |
|
/retest |
| "event_type", "availability_status", | ||
| ), | ||
| }, nil | ||
| } |
There was a problem hiding this comment.
I am assuming no changes were made here.
There was a problem hiding this comment.
There is the one additional header.
|
Image problem again. |
| if config.Telemetry.Enabled { | ||
| var traceHeaders propagation.MapCarrier = make(map[string]string) | ||
| otel.GetTextMapPropagator().Inject(ctx, traceHeaders) | ||
| for name, value := range traceHeaders { | ||
| headers = append(headers, GenericHeader{Key: name, Value: value}) | ||
| } | ||
| } |
There was a problem hiding this comment.
This is the only change in the function, we are not adding the otel header, so we can continue the trace.
My fault this time, working on a fix |
|
/retest |
|
Merged thanks. |
Otel needs a root spans, if that is not passed from external service, we should start one ourselves.
Also jobs shall retrieve these spans and not start new one.
For Jobs:
And for Kafka messages:
