chore: Sanitize job logging #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzap
reviewed
Oct 16, 2023
lzap
reviewed
Oct 16, 2023
|
These are good changes, yeah. |
Cleans up job logs. Removes job_args from most of the job logs except Enqueue and Dequeue. Removes double logging of job id and type.
ezr-ondrej
force-pushed
the
sanitize_job_logging
branch
from
7a6766f to
b16c5c6
Compare
|
All 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁 depends on #711 and thus contains those changes as well
Cleans up job logs.
Removes job_args from most of the job logs except Enqueue and Dequeue.
Removes double logging of job id and type.
I was touching this code quite heavily in #711 so I wanted to follow-up with what I feel might improve the logging a bit.
⚠️ These are my opinions and maybe some of the logs were there on purpose, happy to discuss it! :)