chore: start spans only when telemetry is enabled #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezr-ondrej
force-pushed
the
telemetry_common_tracer
branch
2 times, most recently
from
ff1e4a7 to
1837fe4
Compare
Extract span start into a separate function. This also obsoletes the Tracer naming per package, which is actually correct According to Tracer docs https://pkg.go.dev/go.opentelemetry.io/otel/[email protected]#TracerProvider the passed name should be a name of a tracing library, not the package being intrumented.
ezr-ondrej
force-pushed
the
telemetry_common_tracer
branch
from
1837fe4 to
d8228d9
Compare
|
This is a last bigger change I figured might be worth it when digging through telemetry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract span start into a separate function.
This also obsoletes the Tracer naming per package, which is actually correct
According to Tracer docs https://pkg.go.dev/go.opentelemetry.io/otel/[email protected]#TracerProvider
the passed name should be a name of a tracing library, not the package being intrumented.
Follows #711 with cleanup of
TraceNamewe got it wrong according to docs.More info is also in these nice docs: https://uptrace.dev/opentelemetry/go-tracing.html#tracer