Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing old outputs, renaming folder misc -> img #241

Merged
merged 2 commits into from
Sep 3, 2024
Merged

removing old outputs, renaming folder misc -> img #241

merged 2 commits into from
Sep 3, 2024

Conversation

arik-shurygin
Copy link
Collaborator

part of #236 just some basic housecleaning, removing some really old model images and outputs

@arik-shurygin
Copy link
Collaborator Author

tests are failing because a now unused parameter SAVE_PATH is causing configs to fail. The config.py class will validate and PATH variables to ensure they exist on the machine. However, the actual process of saving output is up the user and not automated by the model (except in the case of the azure runners).

I am going to remove that old variable as a part of this PR.

kokbent
kokbent approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@kokbent kokbent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@arik-shurygin arik-shurygin merged commit 0a3ba3d into main Sep 3, 2024
2 checks passed
@arik-shurygin arik-shurygin deleted the removing-old-output branch September 3, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokbent kokbent kokbent approved these changes

@tjhladish tjhladish Awaiting requested review from tjhladish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arik-shurygin @kokbent