Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 143 and 144 #148

Merged
merged 11 commits into from
Nov 8, 2023

Conversation

CJ-Lee01
Copy link

@CJ-Lee01 CJ-Lee01 commented Nov 7, 2023

#143 : Edits to company names are not reflected in list of applications.
#144 : Editing application names to same name is allowed.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #148 (386703c) into master (579f6d0) will decrease coverage by 0.29%.
The diff coverage is 57.14%.

@@             Coverage Diff              @@
##             master     #148      +/-   ##
============================================
- Coverage     77.45%   77.16%   -0.29%     
- Complexity      916      929      +13     
============================================
  Files            98       98              
  Lines          2896     2943      +47     
  Branches        406      418      +12     
============================================
+ Hits           2243     2271      +28     
- Misses          506      519      +13     
- Partials        147      153       +6     
Files Coverage Δ
...java/seedu/address/logic/commands/EditCommand.java 89.47% <100.00%> (+0.12%) ⬆️
...dress/model/jobapplication/JobApplicationList.java 85.71% <100.00%> (+22.07%) ⬆️
...u/address/model/jobapplication/JobApplication.java 86.84% <20.00%> (-4.71%) ⬇️
...rc/main/java/seedu/address/model/ModelManager.java 78.51% <70.00%> (-1.29%) ⬇️
...java/seedu/address/model/contact/Organization.java 56.86% <31.25%> (-12.59%) ⬇️

@CJ-Lee01 CJ-Lee01 marked this pull request as ready for review November 7, 2023 06:12
@CJ-Lee01 CJ-Lee01 requested review from a team, McNaBry and wamps-jp and removed request for a team November 7, 2023 06:16
@CJ-Lee01 CJ-Lee01 self-assigned this Nov 7, 2023
@CJ-Lee01 CJ-Lee01 added type.FeatureBug A feature isn't working as expected (CS2103T label) priority.High Must do tasks (CS2103T label) severity.Medium A flaw that may hamper app usage or documentation understanding, but is still usable (CS2103T label) labels Nov 7, 2023
@CJ-Lee01 CJ-Lee01 enabled auto-merge November 7, 2023 15:42
Copy link

@McNaBry McNaBry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes to the issues work on my end. Overall, looks good to me.

@CJ-Lee01 CJ-Lee01 merged commit b6c6b46 into AY2324S1-CS2103T-W08-3:master Nov 8, 2023
5 checks passed
@wxwern wxwern linked an issue Nov 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do tasks (CS2103T label) severity.Medium A flaw that may hamper app usage or documentation understanding, but is still usable (CS2103T label) type.FeatureBug A feature isn't working as expected (CS2103T label)
Projects
None yet
2 participants