forked from nus-cs2103-AY2324S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 143 and 144 #148
Merged
CJ-Lee01
merged 11 commits into
AY2324S1-CS2103T-W08-3:master
from
CJ-Lee01:branch-bug-fix
Nov 8, 2023
Merged
Fix issue 143 and 144 #148
CJ-Lee01
merged 11 commits into
AY2324S1-CS2103T-W08-3:master
from
CJ-Lee01:branch-bug-fix
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
============================================
- Coverage 77.45% 77.16% -0.29%
- Complexity 916 929 +13
============================================
Files 98 98
Lines 2896 2943 +47
Branches 406 418 +12
============================================
+ Hits 2243 2271 +28
- Misses 506 519 +13
- Partials 147 153 +6
|
CJ-Lee01
requested review from
a team,
McNaBry and
wamps-jp
and removed request for
a team
November 7, 2023 06:16
CJ-Lee01
added
type.FeatureBug
A feature isn't working as expected (CS2103T label)
priority.High
Must do tasks (CS2103T label)
severity.Medium
A flaw that may hamper app usage or documentation understanding, but is still usable (CS2103T label)
labels
Nov 7, 2023
This was
linked to
issues
Nov 7, 2023
Closed
Closed
McNaBry
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes to the issues work on my end. Overall, looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority.High
Must do tasks (CS2103T label)
severity.Medium
A flaw that may hamper app usage or documentation understanding, but is still usable (CS2103T label)
type.FeatureBug
A feature isn't working as expected (CS2103T label)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#143 : Edits to company names are not reflected in list of applications.
#144 : Editing application names to same name is allowed.