Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester D] Editing application names does not do validation checks #144

Closed
nus-se-script opened this issue Nov 3, 2023 · 0 comments · Fixed by #148
Closed

[PE-D][Tester D] Editing application names does not do validation checks #144

nus-se-script opened this issue Nov 3, 2023 · 0 comments · Fixed by #148
Assignees
@CJ-Lee01
Labels
severity.High Critical issue that may prevent app use entirely (CS2103T label) type.FeatureBug A feature isn't working as expected (CS2103T label)
Milestone
v1.4

Comments

@nus-se-script
Copy link

When applications are added it is checked if there is a repeat but if i edit the name of the application, it does not check and allows me to change it the name to something that can be the same as an existing application

Screenshot 2023-11-03 at 9.29.54 PM.png

Labels: type.FunctionalityBug severity.High
original: mingyu-wan/ped#6
@wxwern wxwern added type.FeatureBug A feature isn't working as expected (CS2103T label) severity.High Critical issue that may prevent app use entirely (CS2103T label) labels Nov 4, 2023
@CJ-Lee01 CJ-Lee01 mentioned this issue Nov 7, 2023
Merged
@CJ-Lee01 CJ-Lee01 self-assigned this Nov 7, 2023
@wxwern wxwern closed this as completed Nov 8, 2023
@wxwern wxwern linked a pull request Nov 8, 2023 that will close this issue
Fix issue 143 and 144 #148
Merged
@wxwern wxwern added this to the v1.4 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CJ-Lee01 CJ-Lee01

Labels
severity.High Critical issue that may prevent app use entirely (CS2103T label) type.FeatureBug A feature isn't working as expected (CS2103T label)
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Fix issue 143 and 144 CJ-Lee01/tp
3 participants
@wxwern @nus-se-script @CJ-Lee01