Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D][Tester D] Relevant company names are not updated if i change an organisation name #143

Closed
nus-se-bot opened this issue Nov 3, 2023 · 1 comment · Fixed by #148
Labels
other.Duplicate This issue or pull request already exists (custom label) severity.High Critical issue that may prevent app use entirely (CS2103T label) type.FeatureBug A feature isn't working as expected (CS2103T label)
Milestone

Comments

@nus-se-bot
Copy link

I understand that an application cannot be applied if the relevant company is not in my organisation list. However, if i change the company name, the name of my company does not change in my application list.

This itself is not actually i problem but it leads to the problem of this job not being recursively deleted when i delete the organisation --recursive

The application for these deleted companies will be cleared if i relaunch jobby, but not immediately after i make the changes

Example:
[ added a application for organisation 1]
Screenshot 2023-11-03 at 8.59.44 PM.png

[ edited the name of organisation 1]
Screenshot 2023-11-03 at 9.00.46 PM.png

[ deleting organisation 1 recursively does not delete the job application ]
Screenshot 2023-11-03 at 9.01.06 PM.png


Labels: type.FeatureFlaw severity.High
original: mingyu-wan/ped#5

@wxwern wxwern added type.FeatureBug A feature isn't working as expected (CS2103T label) severity.High Critical issue that may prevent app use entirely (CS2103T label) other.Duplicate This issue or pull request already exists (custom label) labels Nov 4, 2023
@wxwern
Copy link

wxwern commented Nov 4, 2023

Also partially reported by #126 and #134, but with a better pointer that these two issues are linked (editing company name does not update the job application's data == recursive does not work after that)

@wxwern wxwern removed the other.Duplicate This issue or pull request already exists (custom label) label Nov 4, 2023
@wxwern wxwern added the other.Duplicate This issue or pull request already exists (custom label) label Nov 4, 2023
@CJ-Lee01 CJ-Lee01 added this to the v1.4 milestone Nov 7, 2023
@CJ-Lee01 CJ-Lee01 linked a pull request Nov 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other.Duplicate This issue or pull request already exists (custom label) severity.High Critical issue that may prevent app use entirely (CS2103T label) type.FeatureBug A feature isn't working as expected (CS2103T label)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants