Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[milvus-helm] Update values.yaml - add more comments to externalKafka parameter #41

Closed
wants to merge 1 commit into from
Closed

[milvus-helm] Update values.yaml - add more comments to externalKafka parameter #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/milvus/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,7 @@ externalPulsar:
###################################
# External kafka
# - these configs are only used when `externalKafka.enabled` is true
# - note that the following are just examples, you should confirm the value of brokerList and mechanisms according to the actual external Kafka configuration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better add an example for msk with sasl_ssl in the comment. And for the readability, we should split long comments into separate lines.

###################################
externalKafka:
enabled: false
Expand Down
Loading