Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[milvus-helm] Update values.yaml - add more comments to externalKafka parameter #41

Closed
wants to merge 1 commit into from
Closed

[milvus-helm] Update values.yaml - add more comments to externalKafka parameter #41

wants to merge 1 commit into from

Conversation

wyfeng001
Copy link
Contributor

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wyfeng001
To complete the pull request process, please assign loveeachday after the PR has been reviewed.
You can assign the PR to them by writing /assign @loveeachday in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested a review from zwd1208 December 5, 2023 02:59
@sre-ci-robot
Copy link
Collaborator

Welcome @wyfeng001! It looks like this is your first PR to zilliztech/milvus-helm 🎉

@mergify mergify bot added the ci-passed label Dec 5, 2023
@haorenfsa
Copy link
Collaborator

@wyfeng001 Please sign your commit by git --amend -s

LoveEachDay
LoveEachDay reviewed Jan 2, 2024
View reviewed changes
charts/milvus/values.yaml
@@ -901,6 +901,7 @@ externalPulsar:
###################################
# External kafka
# - these configs are only used when `externalKafka.enabled` is true
# - note that the following are just examples, you should confirm the value of brokerList and mechanisms according to the actual external Kafka configuration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better add an example for msk with sasl_ssl in the comment. And for the readability, we should split long comments into separate lines.

@wyfeng001
Copy link
Contributor Author

Close #41
Open another PR

@wyfeng001 wyfeng001 closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoveEachDay LoveEachDay LoveEachDay left review comments

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees
No one assigned
Labels
ci-passed size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wyfeng001 @sre-ci-robot @haorenfsa @LoveEachDay