simplify load mode selection of iCE40 #80846
Merged
+10
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
cfriedt,
fkokosinski,
msierszulski and
tgorochowik
Replace the enum for load modes for the iCE40 with a boolean flag, as there are only two options: - SPI: default, which should be used whenever possible - GPIO bitbang: workarorund, in case a low-end microcontroller is used Signed-off-by: Benedikt Schmidt <[email protected]>
benediktibk
force-pushed
the
add/ice40_load_modes
branch
from
097d668
to
d9e2694
Compare
|
Btw, the driver is still experimental, therefore a change in the binding should be okay. |
josuah
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the enum for load modes for the iCE40 with a boolean flag, as there are only two options: