-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: xtensa: add M5Stack CoreS3 support #76914
Conversation
Hello @zhxt, and thank you very much for your first pull request to the Zephyr project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I haven't had a chance to look at the schematics yet but can some of these be added to the devicetree? I understand some --but hopefully not all-- of these peripherals are powered through the unsupported (yet!) AXP2101 PMIC's regulators, but it might still make sense to already describe them in the DT.
Yeah, I will try to add some other peripherals to the DT (and will also try to make them work if I can) . A friend of mime will take a look at AXP2101 regulator & AW9532B LED/GPIO controller(also unsupported yet) driver support later days once he has time. |
e89c931
to
4639d56
Compare
b0b2154
to
e4b6ccd
Compare
I am also working on supporting CoreS3 with #79765 based on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also need to fix CI errors.
In Zephyr, when committing to minimal support, it is often submitted with Hello World and blinky working, that is, GPIO and UART working. My PR #79765 and #78098 are also related, so it's better to proceed with the already finished part. |
f919fc6
to
9a7427e
Compare
Yes, agree. The very first commit has hello world working. (but blinky seems rely on the external GPIO controller-aw9523b, there is also a test/wip version implementation https://github.com/zhxt/zephyr/tree/main-gpio-aw9523b), It's very busy on daily work recently, haven't got much time working on this porting, -_- |
74ef3a7
to
12b3cb0
Compare
My PR #79765 contains AXP2101 LED contrl feature support. |
8965e73
to
fa5a0d8
Compare
Yeah, will try to get more time to finish a minimal version. |
@nordicjm Could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit, also my line can be removed from signed off by
Removed. |
Initial support for M5Statck CoreS3 development board. Signed-off-by: Zhang Xingtao <[email protected]> Co-authored-by: Benjamin Cabé <[email protected]> Co-authored-by: TOKITA Hiroshi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @zhxt! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
Initial support for M5Statck CoreS3 development board.