Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: xtensa: add M5Stack CoreS3 support #76914

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

zhxt
Copy link
Contributor

@zhxt zhxt commented Aug 11, 2024

Initial support for M5Statck CoreS3 development board.

Copy link

Hello @zhxt, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I haven't had a chance to look at the schematics yet but can some of these be added to the devicetree? I understand some --but hopefully not all-- of these peripherals are powered through the unsupported (yet!) AXP2101 PMIC's regulators, but it might still make sense to already describe them in the DT.

@zhxt
Copy link
Contributor Author

zhxt commented Aug 12, 2024

Thank you for the PR! I haven't had a chance to look at the schematics yet but can some of these be added to the devicetree? I understand some --but hopefully not all-- of these peripherals are powered through the unsupported (yet!) AXP2101 PMIC's regulators, but it might still make sense to already describe them in the DT.

Yeah, I will try to add some other peripherals to the DT (and will also try to make them work if I can) . A friend of mime will take a look at AXP2101 regulator & AW9532B LED/GPIO controller(also unsupported yet) driver support later days once he has time.

@soburi
Copy link
Member

soburi commented Oct 14, 2024

I am also working on supporting CoreS3 with #79765 based on this.
There are some areas that need improvement, so please consider fixing them.

@zhxt
Copy link
Contributor Author

zhxt commented Oct 14, 2024

I am also working on supporting CoreS3 with #79765 based on this.

There are some areas that need improvement, so please consider fixing them.

@soburi I had got backlight working, but display still need some work to be done.

Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also need to fix CI errors.

boards/m5stack/m5stack_cores3/Kconfig.m5stack_cores3 Outdated Show resolved Hide resolved
boards/m5stack/m5stack_cores3/m5stack_cores3-pinctrl.dtsi Outdated Show resolved Hide resolved
boards/m5stack/m5stack_cores3/m5stack_cores3-pinctrl.dtsi Outdated Show resolved Hide resolved
boards/m5stack/m5stack_cores3/Kconfig.defconfig Outdated Show resolved Hide resolved
@soburi
Copy link
Member

soburi commented Oct 14, 2024

I am also working on supporting CoreS3 with #79765 based on this.
There are some areas that need improvement, so please consider fixing them.

@soburi I had got backlight working, but display still need some work to be done.

In Zephyr, when committing to minimal support, it is often submitted with Hello World and blinky working, that is, GPIO and UART working. My PR #79765 and #78098 are also related, so it's better to proceed with the already finished part.

@zhxt zhxt force-pushed the main branch 2 times, most recently from f919fc6 to 9a7427e Compare October 14, 2024 15:12
@zhxt
Copy link
Contributor Author

zhxt commented Oct 14, 2024

I am also working on supporting CoreS3 with #79765 based on this.
There are some areas that need improvement, so please consider fixing them.

@soburi I had got backlight working, but display still need some work to be done.

In Zephyr, when committing to minimal support, it is often submitted with Hello World and blinky working, that is, GPIO and UART working. My PR #79765 and #78098 are also related, so it's better to proceed with the already finished part.

Yes, agree. The very first commit has hello world working. (but blinky seems rely on the external GPIO controller-aw9523b, there is also a test/wip version implementation https://github.com/zhxt/zephyr/tree/main-gpio-aw9523b),

It's very busy on daily work recently, haven't got much time working on this porting, -_-

@zhxt zhxt force-pushed the main branch 3 times, most recently from 74ef3a7 to 12b3cb0 Compare October 14, 2024 17:04
@soburi
Copy link
Member

soburi commented Oct 15, 2024

I am also working on supporting CoreS3 with #79765 based on this.
There are some areas that need improvement, so please consider fixing them.

@soburi I had got backlight working, but display still need some work to be done.

In Zephyr, when committing to minimal support, it is often submitted with Hello World and blinky working, that is, GPIO and UART working. My PR #79765 and #78098 are also related, so it's better to proceed with the already finished part.

Yes, agree. The very first commit has hello world working. (but blinky seems rely on the external GPIO controller-aw9523b, there is also a test/wip version implementation https://github.com/zhxt/zephyr/tree/main-gpio-aw9523b),

It's very busy on daily work recently, haven't got much time working on this porting, -_-

My PR #79765 contains AXP2101 LED contrl feature support.
So, I think the request to run blinky sample can be aside temporary.
(It not run the real blinky sample, but the same functionality work.)
I think it is good to finish this PR with minimam functionality.

@zhxt zhxt force-pushed the main branch 2 times, most recently from 8965e73 to fa5a0d8 Compare October 15, 2024 17:39
@zhxt
Copy link
Contributor Author

zhxt commented Oct 15, 2024

I am also working on supporting CoreS3 with #79765 based on this.
There are some areas that need improvement, so please consider fixing them.

@soburi I had got backlight working, but display still need some work to be done.

In Zephyr, when committing to minimal support, it is often submitted with Hello World and blinky working, that is, GPIO and UART working. My PR #79765 and #78098 are also related, so it's better to proceed with the already finished part.

Yes, agree. The very first commit has hello world working. (but blinky seems rely on the external GPIO controller-aw9523b, there is also a test/wip version implementation https://github.com/zhxt/zephyr/tree/main-gpio-aw9523b),
It's very busy on daily work recently, haven't got much time working on this porting, -_-

My PR #79765 contains AXP2101 LED contrl feature support. So, I think the request to run blinky sample can be aside temporary. (It not run the real blinky sample, but the same functionality work.) I think it is good to finish this PR with minimam functionality.

Yeah, will try to get more time to finish a minimal version.

boards/m5stack/m5stack_cores3/board.yml Show resolved Hide resolved
boards/m5stack/m5stack_cores3/doc/index.rst Outdated Show resolved Hide resolved
boards/m5stack/m5stack_cores3/doc/index.rst Outdated Show resolved Hide resolved
boards/m5stack/m5stack_cores3/m5stack_cores3_procpu.dts Outdated Show resolved Hide resolved
kartben
kartben previously approved these changes Oct 16, 2024
soburi
soburi previously approved these changes Oct 16, 2024
kartben
kartben previously approved these changes Oct 16, 2024
@soburi soburi added the platform: ESP32 Espressif ESP32 label Oct 16, 2024
@soburi soburi self-assigned this Oct 16, 2024
@zhxt zhxt requested a review from nordicjm October 16, 2024 16:37
@soburi
Copy link
Member

soburi commented Oct 17, 2024

@nordicjm Could you please take a look?

Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, also my line can be removed from signed off by

boards/m5stack/m5stack_cores3/doc/index.rst Outdated Show resolved Hide resolved
boards/m5stack/m5stack_cores3/Kconfig Outdated Show resolved Hide resolved
@zhxt
Copy link
Contributor Author

zhxt commented Oct 22, 2024

minor nit, also my line can be removed from signed off by

Removed.

soburi
soburi previously approved these changes Oct 22, 2024
@soburi soburi requested a review from kartben October 22, 2024 16:44
Initial support for M5Statck CoreS3 development board.

Signed-off-by: Zhang Xingtao <[email protected]>
Co-authored-by: Benjamin Cabé <[email protected]>
Co-authored-by: TOKITA Hiroshi <[email protected]>
Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmahadevan108 mmahadevan108 added this to the v4.1.0 milestone Nov 1, 2024
@nashif nashif merged commit 0cf8660 into zephyrproject-rtos:main Nov 16, 2024
17 checks passed
Copy link

Hi @zhxt!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: ESP32 Espressif ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants