Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte: Revert Tree-sitter grammar upgrade #17404

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

AlbertMarashi
Copy link
Contributor

@AlbertMarashi AlbertMarashi commented Sep 5, 2024

Closes: #17310

This PR #17364 broke my svelte code, downgrading to the previous commit SHA b08d070e303d2a385d6d0ab3add500f8fa514443 fixes the issue.

Until the following issue is resolved, the commit SHA should not be updated

Release Notes:

  • N/A

Copy link

cla-bot bot commented Sep 5, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @AlbertMarashi on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@AlbertMarashi AlbertMarashi changed the title FIx svelte bug by reverting to non-faulty commit version fix: svelte bug by reverting to non-faulty commit version Sep 5, 2024
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 5, 2024
Copy link

cla-bot bot commented Sep 5, 2024

The cla-bot has been summoned, and re-checked this pull request!

@AlbertMarashi AlbertMarashi changed the title fix: svelte bug by reverting to non-faulty commit version fix: svelte bug by reverting to non-faulty commit version & add type syntax highlighting for svelte component tags Sep 5, 2024
@maxdeviant maxdeviant changed the title fix: svelte bug by reverting to non-faulty commit version & add type syntax highlighting for svelte component tags svelte: Revert Tree-sitter grammar upgrade Sep 5, 2024
@zed-industries-bot
Copy link

Messages
📖

This PR includes links to the following GitHub Issues: #Himujjal/tree-sitter-svelte#61
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against 26d7800

@maxdeviant maxdeviant merged commit 0988313 into zed-industries:main Sep 5, 2024
15 checks passed
maxdeviant added a commit that referenced this pull request Sep 5, 2024
This PR bumps the Svelte extension to v0.1.1.

Changes:

- #17404

Release Notes:

- N/A
maxdeviant pushed a commit to zed-extensions/svelte that referenced this pull request Oct 18, 2024
Closes: zed-industries/zed#17310

This PR zed-industries/zed#17364 broke my svelte
code, downgrading to the previous commit SHA
`b08d070e303d2a385d6d0ab3add500f8fa514443` fixes the issue.

Until the following issue is resolved, the commit SHA should not be
updated

- tree-sitter-svelte issue I filed:
Himujjal/tree-sitter-svelte#61

Release Notes:

- N/A
maxdeviant added a commit to zed-extensions/svelte that referenced this pull request Oct 18, 2024
This PR bumps the Svelte extension to v0.1.1.

Changes:

- zed-industries/zed#17404

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax highlighting for Component vs element tags in .svelte files
3 participants