Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svelte: Update Tree-sitter grammar #17323

Merged
merged 2 commits into from
Sep 4, 2024
Merged

svelte: Update Tree-sitter grammar #17323

merged 2 commits into from
Sep 4, 2024

Conversation

matubu
Copy link
Contributor

@matubu matubu commented Sep 3, 2024

Before:
Screenshot from 2024-09-03 20-36-48

After:
Screenshot from 2024-09-03 20-43-44

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 3, 2024
@maxdeviant maxdeviant changed the title svelte: Update Svelte tree sitter svelte: Update Tree-sitter grammar Sep 3, 2024
maxdeviant
maxdeviant reviewed Sep 3, 2024
View reviewed changes
.zed/settings.json Outdated Show resolved Hide resolved
maxdeviant
maxdeviant approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maxdeviant maxdeviant merged commit bde1c95 into zed-industries:main Sep 4, 2024
9 checks passed
@maxdeviant maxdeviant mentioned this pull request Sep 4, 2024
Merged
maxdeviant added a commit that referenced this pull request Sep 4, 2024
@maxdeviant
svelte: Bump to v0.1.0 (#17364)
6b23213 
This PR bumps the Svelte extension to v0.1.0.

Changes:

- #16955
- #17323

Release Notes:

- N/A
@AlbertMarashi
Copy link
Contributor

AlbertMarashi commented Sep 5, 2024 •
edited
Loading

This broke some stuff

image

Notice the error:

image

And the lack of syntax highlighting

osiewicz pushed a commit to CharlesChen0823/zed that referenced this pull request Sep 5, 2024
@matubu @maxdeviant @osiewicz
svelte: Update Tree-sitter grammar (zed-industries#17323)
9eda877 
Before:
![Screenshot from 2024-09-03
20-36-48](https://github.com/user-attachments/assets/c4eca8c9-977b-461c-bb0a-77c0d94554b8)

After:
![Screenshot from 2024-09-03
20-43-44](https://github.com/user-attachments/assets/d9b9653c-29c0-4273-85ee-040fb51af07c)

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <[email protected]>
osiewicz pushed a commit to CharlesChen0823/zed that referenced this pull request Sep 5, 2024
@maxdeviant @osiewicz
svelte: Bump to v0.1.0 (zed-industries#17364)
727078d 
This PR bumps the Svelte extension to v0.1.0.

Changes:

- zed-industries#16955
- zed-industries#17323

Release Notes:

- N/A
@AlbertMarashi
Copy link
Contributor

#17404

@matubu matubu deleted the update-svelte-tree-sitter branch September 6, 2024 14:44
maxdeviant added a commit to zed-extensions/svelte that referenced this pull request Oct 18, 2024
@matubu @maxdeviant
Update Tree-sitter grammar (zed-industries/zed#17323)
8a4728a 
Before:
![Screenshot from 2024-09-03
20-36-48](https://github.com/user-attachments/assets/c4eca8c9-977b-461c-bb0a-77c0d94554b8)

After:
![Screenshot from 2024-09-03
20-43-44](https://github.com/user-attachments/assets/d9b9653c-29c0-4273-85ee-040fb51af07c)

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <[email protected]>
maxdeviant added a commit to zed-extensions/svelte that referenced this pull request Oct 18, 2024
@maxdeviant
Bump to v0.1.0 (zed-industries/zed#17364)
48d0864 
This PR bumps the Svelte extension to v0.1.0.

Changes:

- zed-industries/zed#16955
- zed-industries/zed#17323

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxdeviant maxdeviant maxdeviant approved these changes

Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matubu @AlbertMarashi @maxdeviant