Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomnom is deprecated #103

Open
Rudloff opened this issue Dec 23, 2017 · 8 comments
Open

nomnom is deprecated #103

Rudloff opened this issue Dec 23, 2017 · 8 comments

Comments

@Rudloff
Copy link

Rudloff commented Dec 23, 2017

See https://github.com/harthur/nomnom#deprecation-notice

@jcubic
Copy link

jcubic commented Feb 17, 2018

There is also this project @gerhobbelt/nomnom on npm, which it seems take over the project. So only package.json need to be updated and new version published to npm.

@bdefore
Copy link

bdefore commented Feb 20, 2018

Broke our builds curiously today. Anyone have a fork or alternate library to recommend?

@astorije
Copy link

I'm still crossing my fingers so npm resurrects nomnom, but I'm not too hopeful...

@ehsalazar
Copy link

The nomnom package was no longer being maintained by the original owner. As such, we (npm) deprecated it to give users a heads up. Although you'll get a warning message to that effect, the past versions of the package all remain untouched and available. As for jsonlint, it looks like its dep on nomnom is “>= 1.2.x”, so it was picking up the v2.0.0 deprecate placeholder. We've gone ahead and removed it. I'm sorry for the frustration.

:> npm view nomnom versions
 
[ '0.1.2',
  '0.1.3',
  '0.2.0',
  '0.3.0',
  '0.4.0',
  '0.4.1',
  '0.4.2',
  '0.4.3',
  '0.4.4',
  '0.4.6',
  '0.4.8',
  '0.5.0',
  '0.6.0',
  '0.6.1',
  '1.0.0',
  '1.5.0',
  '1.5.1',
  '1.5.2',
  '1.5.3',
  '1.6.0',
  '1.6.1',
  '1.6.2',
  '1.7.0',
  '1.8.0',
  '1.8.1' ]

@j-brown
Copy link

j-brown commented Feb 21, 2018

ty for the detailed expalantion @ehsalazar ! cheers

@andreineculau
Copy link

I'm sorry to hijack the thread (I don't know where else I should have asked the following), but @ehsalazar would you care to explain further the process? I have a couple of question that I cannot answer based on online docs and individual knowledge:

  1. deprecation of a package version leads to printing a warning oninstall. In this case, as I understand from your comment, npm published version 2.0.0 which only had the deprecation-README.md . Unless a package is in violation of npm's policy (e.g. malware) or creating discomfort (e.g. left-pad or the recent package-missing event), why did npm intervene and publish smth? I don't understand why npm intervened at all, but if so - it seems to have sufficed to mark all versions previously published as deprecated.

  2. no matter who published 2.0.0, another offside move was made IMO - unpublishing, which lead to scenarios like the ones referenced above for mapbox and uber. Wouldn't publishing 2.0.1 have done the job nicely? I'm asking you because, once again as per my understanding, it's npm that published 2.0.0 not the package author.

Thanks!

@timclipsham
Copy link

@ehsalazar I'd like more information on this too, as yesterday we had stable builds we intended to release today. Now that build is broken upon attempting to deploy because a dependency deep in the project (referenced in our package-lock.json file) no longer has v2.0.0 published.

@ehsalazar
Copy link

@andreineculau action was taken only after being in communication with the previous owner.

@timclipsham if you delete your package-lock.json, run a cache clean and new install, that should link you back to v1.8.1 and should fix your dep issues.

anandthakker pushed a commit to mapbox/mapbox-gl-js that referenced this issue Mar 2, 2018
anandthakker pushed a commit to mapbox/mapbox-gl-js that referenced this issue Mar 6, 2018
anandthakker pushed a commit to mapbox/mapbox-gl-js that referenced this issue Mar 7, 2018
anandthakker pushed a commit to mapbox/mapbox-gl-js that referenced this issue Mar 7, 2018
anandthakker pushed a commit to mapbox/mapbox-gl-js that referenced this issue Mar 7, 2018
anandthakker pushed a commit to mapbox/mapbox-gl-js that referenced this issue Mar 7, 2018
anandthakker pushed a commit to mapbox/mapbox-gl-js that referenced this issue Mar 9, 2018
anandthakker pushed a commit to mapbox/mapbox-gl-js that referenced this issue Mar 11, 2018
anandthakker pushed a commit to mapbox/mapbox-gl-js that referenced this issue Mar 12, 2018
anandthakker added a commit to mapbox/mapbox-gl-js that referenced this issue Mar 12, 2018
* [codemod] convert src/ from commonjs to es6 modules

Using 5to6-codemod/transforms/{cjs,exports,named-export-generation}.js

* [codemod] convert bench/ to use import instead of require()

5to6-codemod/transforms/cjs.js

* [codemod] Convert util.* to use named imports

https://gist.github.com/anandthakker/b636ad8cb7782c47998c4de9c0c5419d

* Setup rollup

* Manual es6 module fixes

* Fix(ish) codegen

* Apply fixed codegen

* Add flow-remove-types require hook using pirates

Upstream: facebookarchive/flow-remove-types#62

* Update docs site to use es module import

* Upgrade batfish

* Update benchmarks build

* Update style-spec build

* [codemod] Convert test/unit to use import instead of require

5to6 cjs transform

* Workaround for standard-things/esm#301

* Add scripts to run node/tap with require hooks

* [codemod] test/unit no-strict

* Avoid @std/esm 'temporal dead zone' warning

* Fixup unit tests

* Add comments explaining bundling strategy

* Update integration test suite implementation

* Update yarn.lock

Specifically for zaach/jsonlint#103 (comment)

* Polish build

- Remove browserify
- Update build tests

* [lint] Use sourceType: script for test/integration/

* [lint] Add eslint-plugin-import, fix lint in src/

* [lint] Fix lint in test/

* [lint] Fix lint in bench/

* [lint] Fix lint for docs/

* Fix rollup config warning

* Move rollup plugins to devDependencies

* Use @mapbox-scoped rollup while awaiting upstream merge

* Move comment in benchmarks.js

* Restore comments stripped by codemods

* Fix Style#queryRenderedFeature unit tests
vintrepid pushed a commit to vintrepid/lore-tutorial-api that referenced this issue Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants