Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump The Lounge to v2.7.1 #28

Merged
merged 2 commits into from
Feb 19, 2018
Merged

Bump The Lounge to v2.7.1 #28

merged 2 commits into from
Feb 19, 2018

Conversation

@astorije astorije merged commit c53ec34 into master Feb 19, 2018
@astorije astorije deleted the astorije/2.7.1 branch February 19, 2018 05:31
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2018 Jérémie Astori
Copyright (c) 2015 Jérémie Astori

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was not intentional

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing, @andreineculau!
It was intentional actually, and the reason is the same as mentioned here: thelounge/thelounge-deb#16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You say there that you believe in bumping the copyright years when the project is updated. You have already done so in January 2018 for this project. Here you reversed the change. Anyways, i was nitpicking while looking at the actual jsonlint disabling

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I meant specifically xPaw's comment:

My understanding is that copyright years shouldn't be updated. https://stackoverflow.com/a/2391555/2200891

So most likely I was wrong, and corrected my wrong here :)

Yeah, disabling jsonlint isn't great, but npm...

@andreineculau
Copy link

andreineculau commented Feb 19, 2018 via email

astorije added a commit that referenced this pull request Feb 25, 2018
Upstream project was fixed. See #28
@astorije astorije mentioned this pull request Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants