-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump The Lounge to v2.7.1 #28
Conversation
@@ -1,6 +1,6 @@ | |||
The MIT License (MIT) | |||
|
|||
Copyright (c) 2018 Jérémie Astori | |||
Copyright (c) 2015 Jérémie Astori |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this was not intentional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing, @andreineculau!
It was intentional actually, and the reason is the same as mentioned here: thelounge/thelounge-deb#16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You say there that you believe in bumping the copyright years when the project is updated. You have already done so in January 2018 for this project. Here you reversed the change. Anyways, i was nitpicking while looking at the actual jsonlint disabling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I meant specifically xPaw's comment:
My understanding is that copyright years shouldn't be updated. https://stackoverflow.com/a/2391555/2200891
So most likely I was wrong, and corrected my wrong here :)
Yeah, disabling jsonlint
isn't great, but npm...
Aha :)
Re:jsonlint yeah, always great to find old stuff that always worked just stop working...
… On 19 Feb 2018, at 18:36, Jérémie Astori ***@***.***> wrote:
@astorije commented on this pull request.
In LICENSE:
> @@ -1,6 +1,6 @@
The MIT License (MIT)
-Copyright (c) 2018 Jérémie Astori
+Copyright (c) 2015 Jérémie Astori
Right, I meant specifically xPaw's comment:
My understanding is that copyright years shouldn't be updated. https://stackoverflow.com/a/2391555/2200891
So most likely I was wrong, and corrected my wrong here :)
Yeah, disabling jsonlint isn't great, but npm...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Upstream project was fixed. See #28
Disabling
jsonlint
for now because: