Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement gn.py as discussed in design review #4427

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −7
Draft

Implement gn.py as discussed in design review #4427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,11 @@ exec_script_whitelist =
"//tools/gritsettings/BUILD.gn",
]

# TODO(b/378960295): Convert python scripts to GN actions.
import("//cobalt/build/configs/cobalt.gni")
if (is_cobalt) {
exec_script_whitelist += [
"//starboard/tools/BUILD.gn",
"//starboard/build/config/sabi/BUILD.gn",
"//starboard/build/platform_path.gni",
]
}

2 changes: 2 additions & 0 deletions cobalt/build/configs/android-arm/args.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,6 @@ clang_use_chrome_plugins = false
enable_check_raw_ptr_fields = false

# This flag comes from build/config/compiler/compiler.gni
is_cobalt = true

treat_warnings_as_errors = false
2 changes: 2 additions & 0 deletions cobalt/build/configs/android-arm64/args.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,6 @@ clang_use_chrome_plugins = false
enable_check_raw_ptr_fields = false

# This flag comes from build/config/compiler/compiler.gni
is_cobalt = true

treat_warnings_as_errors = false
2 changes: 2 additions & 0 deletions cobalt/build/configs/android-x86/args.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,6 @@ clang_use_chrome_plugins = false
enable_check_raw_ptr_fields = false

# This flag comes from build/config/compiler/compiler.gni
is_cobalt = true

treat_warnings_as_errors = false
1 change: 0 additions & 1 deletion cobalt/build/configs/chromium_android-arm/args.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
target_os = "android"
target_cpu = "arm"
is_cobalt = false
1 change: 0 additions & 1 deletion cobalt/build/configs/chromium_android-arm64/args.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
target_os = "android"
target_cpu = "arm64"
is_cobalt = false
1 change: 0 additions & 1 deletion cobalt/build/configs/chromium_android-x86/args.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
target_os = "android"
target_cpu = "x86"
is_cobalt = false
1 change: 0 additions & 1 deletion cobalt/build/configs/chromium_linux-x64x11/args.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
target_os = "linux"
target_cpu = "x64"
is_cobalt = false

# TODO(b/376141256): Decide if this flag is needed here or in .gclient file
chrome_pgo_phase = 0
2 changes: 1 addition & 1 deletion cobalt/build/configs/cobalt.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
# configuration.

declare_args() {
is_cobalt = true
is_cobalt = false
}
1 change: 1 addition & 0 deletions cobalt/build/configs/linux-x64x11/args.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
target_os = "linux"
target_cpu = "x64"
is_cobalt = true

use_ozone = true

Expand Down
Loading