Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement gn.py as discussed in design review #4427

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implement gn.py as discussed in design review #4427

wants to merge 1 commit into from
+10 −7

Conversation

niranjanyardi
Copy link
Contributor

b/377271824

Set is_cobalt = false in GN code

@niranjanyardi niranjanyardi requested a review from a team as a code owner November 13, 2024 22:22
@niranjanyardi niranjanyardi marked this pull request as draft November 13, 2024 22:22
@niranjanyardi niranjanyardi force-pushed the gn_py_changes branch 3 times, most recently from 8c11c72 to feb328c Compare November 13, 2024 23:59
@niranjanyardi niranjanyardi requested review from briantting and removed request for briantting November 14, 2024 01:03
@niranjanyardi niranjanyardi mentioned this pull request Nov 15, 2024
Merged
@niranjanyardi
Copy link
Contributor Author

OPen comments:

https://github.com/youtube/cobalt/pull/4439/files#r1844361783
https://github.com/youtube/cobalt/pull/4439/files#r1844360468

oxve
oxve approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@oxve oxve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxve oxve oxve approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niranjanyardi @oxve