Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcorner 15 create account page #101

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Xcorner 15 create account page #101

merged 7 commits into from
Feb 12, 2024

Conversation

mgbelegu
Copy link
Collaborator

Changes:

  • Styled create account page
  • Some style changes and refactoring based on stylelint warnings
  • Modified prettier config to ignore HTML files since prettier will break handlebars code

@mgbelegu mgbelegu changed the base branch from master to xcorner-v2 January 24, 2024 12:49
@mgbelegu mgbelegu force-pushed the XCORNER-15-create-account-page branch from f2b9c7b to e3bb97b Compare February 5, 2024 09:04
marcinkrzeminski
marcinkrzeminski suggested changes Feb 5, 2024
View reviewed changes
assets/scss/pages/auth-page.scss Outdated Show resolved Hide resolved
assets/scss/pages/auth-page.scss Outdated Show resolved Hide resolved
assets/scss/pages/auth-page.scss Outdated Show resolved Hide resolved
assets/scss/pages/auth-page.scss Outdated Show resolved Hide resolved
assets/scss/pages/auth-page.scss Outdated Show resolved Hide resolved
assets/scss/pages/contact-page.scss Outdated Show resolved Hide resolved
assets/scss/pages/contact-page.scss Outdated Show resolved Hide resolved
@mgbelegu mgbelegu force-pushed the XCORNER-15-create-account-page branch from 547a257 to cce6c46 Compare February 6, 2024 09:38
@mgbelegu
Copy link
Collaborator Author

mgbelegu commented Feb 6, 2024

@marcinkrzeminski Can you please review again?

@mgbelegu mgbelegu requested review from marcinkrzeminski and removed request for aleksandraworhacz February 6, 2024 09:40
@mgbelegu mgbelegu self-assigned this Feb 6, 2024
marcinkrzeminski
marcinkrzeminski suggested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@marcinkrzeminski marcinkrzeminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgbelegu just one small thing and you're good to go.

assets/scss/pages/login-page.scss Outdated Show resolved Hide resolved
@marcinkrzeminski marcinkrzeminski mentioned this pull request Feb 9, 2024
Merged
@mgbelegu mgbelegu merged commit 85c9181 into xcorner-v2 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcinkrzeminski marcinkrzeminski marcinkrzeminski requested changes

Assignees

@mgbelegu mgbelegu

Labels
Code Review Waiting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgbelegu @marcinkrzeminski