Xcorner 16 reset password page #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgbelegu
force-pushed
the
XCORNER-16-reset-password-page
branch
from
96e8447
to
75fb3e9
Compare
mgbelegu
force-pushed
the
XCORNER-16-reset-password-page
branch
from
395f1d9
to
59e1ba9
Compare
|
@marcinkrzeminski Can you please review this? |
marcinkrzeminski
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
@mgbelegu this one is approved but, but please merge the changes from first. #101 (review)
assets/scss/pages/auth-page.scss
Outdated
Comment on lines
292
to
347
| .c-forgot-password-page { | ||
| .page-title { | ||
| color: $color-black; | ||
| font-family: $font-semi-bold; | ||
| font-size: 2rem; | ||
| font-style: normal; | ||
| font-weight: 600; | ||
| line-height: 2.5rem; | ||
| } | ||
| } | ||
|
|
||
| .c-forgot-password-container { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 1.5rem; | ||
|
|
||
| @include bp(medium) { | ||
| gap: 3rem; | ||
| } | ||
| } | ||
|
|
||
| .c-forgot-password-intro { | ||
| max-width: 48.875rem; | ||
| margin: 0; | ||
|
|
||
| color: $color-neutrals-500; | ||
| font-family: $font-regular; | ||
| font-size: 1.125rem; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| line-height: 1.33; | ||
| } | ||
|
|
||
| .c-forgot-password-form { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 1.5rem; | ||
|
|
||
| .c-form__text-input { | ||
| width: 100%; | ||
|
|
||
| @include bp(medium) { | ||
| max-width: 20rem; | ||
| } | ||
| } | ||
|
|
||
| .c-button { | ||
| @include bp(medium) { | ||
| width: fit-content; | ||
| } | ||
| } | ||
|
|
||
| br { | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
@mgbelegu move all of that to a separate component please. I suggest p-forgot-password as the root class name.
mgbelegu
force-pushed
the
XCORNER-16-reset-password-page
branch
from
162fe92
to
390eda7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.