fixed radio button spacing with css #654
Conversation
| @@ -138,13 +152,13 @@ ul.btn-group { | |||
| flex-grow: 0.25 !important; | |||
| } | |||
| .control.checkbox-container { | |||
| flex-flow: unset; | |||
| flex-flow: unset;; | |||
| } | |||
| .control.checkbox-container label { | |||
There was a problem hiding this comment.
Why isn't this rule specific enough? Why the extra class?
There was a problem hiding this comment.
I will try your suggestion. I found I needed separate styling for the radio-group labels and the checkbox labels, so that visually they look similar.
There was a problem hiding this comment.
OK, it worked, thanks!
There was a problem hiding this comment.
wondering about the checkbox-group on MIDIView, would you prefer it on 2 lines (like elsewhere in the app)? I had to make a scoped style for it....
There was a problem hiding this comment.
I think MIDI view deserves dedicated styles. That many checkboxes in a row is once-in-an-app exception.
|
Do all the labels. There's some you missed in e.g. ExpandScale.vue. |
|
Code-wise looks good. Too many commits, but I can squash when merging on GitHub. Will review the UI after breakfast. |
|
Good job! Squashing and merging. |
No description provided.