Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Make checkbox gaps slightly wider #644

Closed
frostburn opened this issue Apr 12, 2024 · 5 comments
Closed

UI: Make checkbox gaps slightly wider #644

frostburn opened this issue Apr 12, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@frostburn
Copy link
Member

Some of the <label> elements have explicit space characters in them. This doesn't look neat in template code. The gap should be controlled by CSS alone.

@frostburn frostburn added the enhancement New feature or request label Apr 12, 2024
@frostburn
Copy link
Member Author

Assigning to Marc in reference to https://github.com/xenharmonic-devs/scale-workshop/pull/642/files#r1562023627 .

@000masa000
Copy link
Contributor

copying the comment to contoinue discussion here:
for now in main.css I replaced "select-group" with "dropdown-group" and also added "checkbox-group" to match the already existing "radio-group". Not sure but it seemed to make sense that a row of each of these HTML elements might need different spacing. Any thoughts about best way to implement this?

@000masa000
Copy link
Contributor

what class name should be given to labels that fall to the right of an input (checkbox, radio button, number) : these need a gap to the left of the text?

@frostburn
Copy link
Member Author

what class name should be given to labels that fall to the right of an input (checkbox, radio button, number) : these need a gap to the left of the text?

I don't think they need a name. CSS rules should be able to specify label elements within a checkbox container.

@frostburn
Copy link
Member Author

PR was #654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants