Add a toggle for interval matrix indexing (Issue #411) #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an interval matrix indexing option (default zero-indexing).
|
Added radio buttons for "Interval indexing": 0-indexing (default) and 1-indexing. |
|
|
The commit message should end with |
|
Or do we actually have duplicate issues? #411 is just fine then. |
inthar-raven
changed the title
`label for=` should refer to the id's.
frostburn
reviewed
Nov 27, 2023
src/views/AnalysisView.vue
Outdated
| </th> | ||
| <th>({{ scale.size + 1 }})</th> | ||
| <th>({{ scale.size + indexing.value }})</th> |
There was a problem hiding this comment.
In <template> code this is just called indexing. Now it shows NaNs.
|
Recommend doing |
"indexing.value" -> "indexing"
frostburn
reviewed
Nov 27, 2023
| <input | ||
| type="radio" | ||
| id="indexing-zero" | ||
| value=0 |
There was a problem hiding this comment.
This cause the value to become a string which messes up the UI.
This was
linked to
issues
Nov 27, 2023
Added reactivity for Issue #411.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.