Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a toggle for interval matrix indexing #411

Closed
frostburn opened this issue Mar 25, 2023 · 0 comments
Closed

Add a toggle for interval matrix indexing #411

frostburn opened this issue Mar 25, 2023 · 0 comments
Milestone
User requests

Comments

@frostburn
Copy link
Member

intars (accidentally Latvian) — Today at 2:46 AM

@ Sevish @ frostburn I wish the interval matrix in Scale Workshop used zero-indexing for degrees.
Zero-indexing (I use "k-step" and "k-degree", where the "perfect 0-step/degree" is the unison/tonic) is just much better for referring to intervals and degrees in arbitrary scales.

Scott Dakota — Today at 3:14 AM

A toggle switch for zero-index or one-index could be handy.
@frostburn frostburn added this to the User requests milestone May 20, 2023
@frostburn frostburn mentioned this issue Nov 27, 2023
Closed
@frostburn frostburn linked a pull request Nov 27, 2023 that will close this issue
Add a toggle for interval matrix indexing (Issue #411) #500
Closed
@inthar-raven inthar-raven mentioned this issue Nov 28, 2023
Merged
inthar-raven added a commit to inthar-raven/scale-workshop that referenced this issue Nov 29, 2023
@inthar-raven
Issue xenharmonic-devs#411, add radio buttons to change the indexing …
995ab97 
…of the top row of the interval matrix in Analysis view.

Add files via upload

Update AnalysisView.vue

The table now keeps the 0-step column for both 0-indexed and 1-indexed, so we can now address xenharmonic-devs#445 if we want.

Update AnalysisView.vue

`indexing` -> `intervalMatrixIndexing`

Update App.vue

Persist `intervalMatrixIndex` in local storage

Update AnalysisView.vue

emit value `intervalMatrixIndex` to persist it

Add files via upload

Add files via upload

Add files via upload

`intervalMatrixIndexing` is now a `number`.

`intervalMatrixIndexing` is now a `number`.

Update AnalysisView.vue

`value="0"` etc. -> `:value="0"` etc.

Update AnalysisView.vue

Update AnalysisView.vue

Make sure to parse the integer emitted by indexing radio buttons as decimal

Update AnalysisView.vue

Update analysis.ts

startIndex is not necessary yet (issue xenharmonic-devs#445 should be dealt with separately)
inthar-raven added a commit to inthar-raven/scale-workshop that referenced this issue Nov 29, 2023
@inthar-raven
Issue xenharmonic-devs#411, add radio buttons to change the indexing …
44c2479 
…of the top row of the interval matrix in Analysis view.
frostburn added a commit that referenced this issue Nov 29, 2023
@frostburn
Merge pull request #501 from inthar-raven/main
fe1717d 
Issue #411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
User requests
Development

Successfully merging a pull request may close this issue.

Add a toggle for interval matrix indexing (Issue #411)
2 participants
@frostburn @inthar-raven