Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lightweight tempering algorithms for large subgroups #398

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

frostburn
Copy link
Member

ref #397

@frostburn frostburn linked an issue Jan 2, 2023 that may be closed by this pull request
@frostburn frostburn force-pushed the lightweight-tempering branch from 5d30d5c to b33a8e7 Compare January 7, 2023 19:30
@frostburn
Copy link
Member Author

Went ahead and included mathjs higher upstream as it could simplify some matrix calculations there anyway.

@frostburn
Copy link
Member Author

I need to look into this and describe how to test.

@frostburn frostburn force-pushed the lightweight-tempering branch from b33a8e7 to 4fa617b Compare February 26, 2023 13:45
@frostburn
Copy link
Member Author

To test load a JI preset like Raga Bageshri and apply the Temper modifier with prime limit set to something high like 41. In main that eventually crashes something, but in this branch it should work.

@frostburn frostburn force-pushed the lightweight-tempering branch from 4fa617b to 7741182 Compare November 26, 2023 10:33
@frostburn
Copy link
Member Author

Self-reviewing: For the love of Spoob, why are we like this?!

@frostburn frostburn merged commit d1dd036 into main Nov 26, 2023
1 check passed
@frostburn frostburn deleted the lightweight-tempering branch November 26, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for tempering in huge subgroups
1 participant