Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tempering in huge subgroups #397

Closed
frostburn opened this issue Dec 31, 2022 · 3 comments · Fixed by #398
Closed

Add support for tempering in huge subgroups #397

frostburn opened this issue Dec 31, 2022 · 3 comments · Fixed by #398
Labels
enhancement New feature or request

Comments

@frostburn
Copy link
Member

Userminusone — 12/24/2022 5:39 AM

So it turns out ScaleWorkshop tempering via commas just... fails with high prime limits?

Is this a bug or am I not supposed to go up to the 31 limit with tempering?

This is related to: xenharmonic-devs/temperaments#30

@frostburn frostburn added the enhancement New feature or request label Dec 31, 2022
@frostburn
Copy link
Member Author

I think the best I can do for now is making commas disappear via generic gradient descent and adding vals in Tenney-Euclid optimal linear combinations. I should be able to keep equaves pure, but not support arbitrary constraints.

@frostburn
Copy link
Member Author

Note that this doesn't apply to scale generation. Those remain off-limits for now.

You need the wedgie to work out the period and the generator. The naive way of calculating the wedgie grows like 2**n in complexity. There might be a n**2 solution, but I haven't figured it out yet.

The numerical methods for working out periods and generators from mapping vectors are somewhat flimsy. Producing the wrong result or randomly failing is not great for UX.

@frostburn
Copy link
Member Author

I guess I'll implement everything in this repository for now. Can't see a reasonable way around adding mathjs dependency and don't want to burden temperaments with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant